Small Bug and Patch (?) for RTIR V2.4.1

Greetings,

I just installed RT V3.8.2 with RTIR V2.4.1 this week. I found what I believe is a bug in RTIR that manifests itself when the WebPath of RT is not at the document root of the web server. It’s triggered when one is trying to create a new Article for an Incident or an Incident Report. The HREF for the Article “new” link has the “next” parameter hardcoded as “/RTIR/Display.html?id=$id” when it should include the configured WebPath. Therefore when clicking “Create” after entering the new Article, one receives a 404 error “The requested URL /RTIR/Display.html was not found on this server”

Below is the fix I installed. I am new this week to RT and Mason (thank goodness I recognized Perl ), so I freely admit that I might be missing something and there may be a better way to fix this problem. If so I apologize. I would appreciate some feedback.

Deb

diff -r local/plugins/RT-IR/html/RTIR/Display.html local/plugins/RT-IR/html/RTIR-orig/Display.html
158c158
< % my $qs = $m->comp("/Elements/QueryString", “RefersTo-new” => “t:$id”, next => RT->Config->Get(‘WebPath’)."/RTIR/Display.html?id=$id");

% my $qs = $m->comp("/Elements/QueryString", “RefersTo-new” => “t:$id”, next => “/RTIR/Display.html?id=$id”);
diff -r local/plugins/RT-IR/html/RTIR/Incident/Display.html local/plugins/RT-IR/html/RTIR-orig/Incident/Display.html
172c172
< % my $qs = $m->comp("/Elements/QueryString", “RefersTo-new” => “t:$id”, next => RT->Config->Get(‘WebPath’)."/RTIR/Display.html?id=$id");

Deb,

Thanks, this patch looks good at first glance. I’ve forwarded it to
rtir-bugs to make sure it gets itself into the codebase.On Fri 6.Mar’09 at 9:55:27 -0700, Schutt, Deborah A wrote:

Greetings,

I just installed RT V3.8.2 with RTIR V2.4.1 this week. I found what I
believe is a bug in RTIR that manifests itself when the WebPath of RT is
not at the document root of the web server. It’s triggered when one is
trying to create a new Article for an Incident or an Incident Report. The
HREF for the Article “new” link has the “next” parameter hardcoded as
"/RTIR/Display.html?id=$id" when it should include the configured WebPath.
Therefore when clicking “Create” after entering the new Article, one
receives a 404 error “The requested URL /RTIR/Display.html was not found
on this server”

Below is the fix I installed. I am new this week to RT and Mason (thank
goodness I recognized Perl ), so I freely admit that I might be
missing something and there may be a better way to fix this problem. If so
I apologize. I would appreciate some feedback.

Deb

diff -r local/plugins/RT-IR/html/RTIR/Display.html
local/plugins/RT-IR/html/RTIR-orig/Display.html
158c158
< % my $qs = $m->comp("/Elements/QueryString", “RefersTo-new” => “t:$id”,
next => RT->Config->Get(‘WebPath’)."/RTIR/Display.html?id=$id");

% my $qs = $m->comp("/Elements/QueryString", “RefersTo-new” => “t:$id”,
next => “/RTIR/Display.html?id=$id”);
diff -r local/plugins/RT-IR/html/RTIR/Incident/Display.html
local/plugins/RT-IR/html/RTIR-orig/Incident/Display.html
172c172
< % my $qs = $m->comp("/Elements/QueryString", “RefersTo-new” => “t:$id”,
next => RT->Config->Get(‘WebPath’)."/RTIR/Display.html?id=$id");


% my $qs = $m->comp("/Elements/QueryString", “RefersTo-new” => “t:$id”,
next => “/RTIR/Display.html?id=$id”);


List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel