Silence a warning in CustomField_Overlay.pm

RT Developers
1

This diff applies against 3.4.5

— lib/RT/CustomField_Overlay.pm.orig Thu Sep 22 15:09:22 2005
+++ lib/RT/CustomField_Overlay.pm Wed May 10 16:29:09 2006
@@ -876,10 +876,10 @@ sub AddToObject {
if ( $ObjectCF->Id ) {
return ( 0, $self->loc(“That is already the current value”) );
}

  • my ( $id, $msg ) =
  •  $ObjectCF->Create( ObjectId => $id, CustomField => $self->Id );
  • my ( $oid, $msg ) =
  •  $ObjectCF->Create( ObjectId => $id, CustomField => $self->Id );
  • return ( $id, $msg );
  • return ( $oid, $msg );
    }

@@ -911,9 +911,9 @@ sub RemoveFromObject {
unless ( $ObjectCF->Id ) {
return ( 0, $self->loc(“This custom field does not apply to that object”) );
}

  • my ( $id, $msg ) = $ObjectCF->Delete;
  • my ( $oid, $msg ) = $ObjectCF->Delete;
  • return ( $id, $msg );
  • return ( $oid, $msg );
    }

{{{ AddValueForObject

2

I don’t have a record of saying “Thanks, Applied”, but it happened
some time ago. Thanks! Applied. (though possibly by Ruslan, Kevin or
Alex)

JesseOn May 10, 2006, at 4:30 PM, Mathieu Sauve-Frankel wrote:

This diff applies against 3.4.5

— lib/RT/CustomField_Overlay.pm.orig Thu Sep 22 15:09:22 2005
+++ lib/RT/CustomField_Overlay.pm Wed May 10 16:29:09 2006
@@ -876,10 +876,10 @@ sub AddToObject {
if ( $ObjectCF->Id ) {
return ( 0, $self->loc(“That is already the current
value”) );
}

  • my ( $id, $msg ) =
  •  $ObjectCF->Create( ObjectId => $id, CustomField => $self->Id );
  • my ( $oid, $msg ) =
  •  $ObjectCF->Create( ObjectId => $id, CustomField => $self->Id );
  • return ( $id, $msg );
  • return ( $oid, $msg );
    }

@@ -911,9 +911,9 @@ sub RemoveFromObject {
unless ( $ObjectCF->Id ) {
return ( 0, $self->loc(“This custom field does not apply
to that object”) );
}

  • my ( $id, $msg ) = $ObjectCF->Delete;
  • my ( $oid, $msg ) = $ObjectCF->Delete;
  • return ( $id, $msg );
  • return ( $oid, $msg );
    }

{{{ AddValueForObject

List info: lists.bestpractical.com Mailing Lists
rt-devel

Best Practical is hiring! Come hack Perl for us: http://
Careers — Best Practical Solutions

PGP.sig (186 Bytes)