Same description for tow different owner change transactions

Loos_Christian · April 10, 2014, 11:59am

Hi,

if you change a ticket owner from ‘Nobody to Somebody’ or from ‘Me to
Somebody’, both transactions are shown in the ticket history as ‘Given
to Somebody’ (see [1] and [2])
By looking at the history you can’t see if the ticket was previously
owned by Nobody or by Me.

One of the txn descriptions should be changed, but I’m not quite sure
which one.
My suggestions:

Nobody->Somebody: ‘Owner set to Somebody’
Me->Somebody: ‘Owner changed from Me to Somebody’

Chris

[1]

github.com

bestpractical/rt/blob/stable/lib/RT/Transaction.pm#L1123


      
              return ( "[_1] [_2] added", $self->_CanonicalizeRoleName($self->Field), $self->_FormatPrincipal($principal));    #loc()
          },
          DelWatcher => sub {
              my $self = shift;
              my $principal = RT::Principal->new($self->CurrentUser);
              $principal->Load($self->OldValue);
              return ( "[_1] [_2] deleted", $self->_CanonicalizeRoleName($self->Field), $self->_FormatPrincipal($principal));  #loc()
          },
          SetWatcher => sub {
              my $self = shift;
              my $principal = RT::Principal->new($self->CurrentUser);
              $principal->Load($self->NewValue);
              return ( "[_1] set to [_2]", $self->_CanonicalizeRoleName($self->Field), $self->_FormatPrincipal($principal));  #loc()
          },
          Subject => sub {
              my $self = shift;
              return ( "Subject changed to [_1]", $self->Data );  #loc()
          },
          AddLink => sub {
              my $self = shift;
              my $value;

[2]

github.com

bestpractical/rt/blob/stable/lib/RT/Transaction.pm#L1135


      
              return ( "[_1] set to [_2]", $self->_CanonicalizeRoleName($self->Field), $self->_FormatPrincipal($principal));  #loc()
          },
          Subject => sub {
              my $self = shift;
              return ( "Subject changed to [_1]", $self->Data );  #loc()
          },
          AddLink => sub {
              my $self = shift;
              my $value;
              if ( $self->NewValue ) {
                  my $URI = RT::URI->new( $self->CurrentUser );
                  if ( $URI->FromURI( $self->NewValue ) ) {
                      $value = [
                          \'<a href="', $URI->AsHREF, \'">',
                          $URI->AsString,
                          \'</a>'
                      ];
                  }
                  else {
                      $value = $self->NewValue;
                  }

Kevin_Falcone · April 10, 2014, 5:14pm

if you change a ticket owner from ‘Nobody to Somebody’ or from ‘Me to
Somebody’, both transactions are shown in the ticket history as ‘Given
to Somebody’ (see [1] and [2])
By looking at the history you can’t see if the ticket was previously
owned by Nobody or by Me.

One of the txn descriptions should be changed, but I’m not quite sure
which one.
My suggestions:

Nobody->Somebody: ‘Owner set to Somebody’

Me->Somebody: ‘Owner changed from Me to Somebody’

I agree that this is confusing. It’s actually confusing in 4.0 too
(at least in my testing I see the same language).

My biggest concern with clarifying this is trying to reuse some
already translated language from elsewhere in RT if we can.
Any thoughts with that in mind?
If I was starting fresh, I might say “Assigned to Somebody” as the
Nobody->Somebody transition, but I’m not convinced that’s right.

Loos_Christian · April 11, 2014, 6:13am

I agree that this is confusing. It’s actually confusing in 4.0 too
(at least in my testing I see the same language).

My biggest concern with clarifying this is trying to reuse some
already translated language from elsewhere in RT if we can.
Any thoughts with that in mind?
If I was starting fresh, I might say “Assigned to Somebody” as the
Nobody->Somebody transition, but I’m not convinced that’s right.

If we want to reuse existing translations the one thing we can do is
changing Me->Somebody to ‘Owner changed from Me to Sombody’ for RT 4.0
and 4.2 as I couldn’t find anything else that we can use from the
existing translations.

I like your ‘Assigned to Somebody’.
So for 4.4 we can change Me->Somebody back to ‘Given to Somebody’ and
use ‘Assigned to Somebody’ for Nobody->Somebody.

Chris