RT-Extension-MobileUI : Not all Saved Searches are shown on Home page

Hi

I am experimenting with RT-Extension-MobileUI 1.01 on RT 3.8.8.

I am surprised by the Saved Searches on the home page.
The Home page lists 8 Saved Searches
whereas when I go to the Search Builder I have 13.

I don’t see any commonality between the shown Saved Searches
or between the unshown Saved Searches.
Privacy does not seem to influence this :
I am missing some but not all searches from "My Saved Searches"
and also missing some but not all searches from “MyCompany Everybody’s
saved searches”
(I have a group called “MyCompany Everybody”)

Another of my colleagues sees the same thing :
she sees only 2 searches from the 5 “MyCompany Everybody’s saved searches”.
(the same as me).
She does not see any searches from her 6 “My Saved Searches”.
She does not see any searches from the 3 with yet another privacy.

Has anyone had a similar issue ?

Regards
Gerard

Apparently for the missing Searches
$search->SubValue(“SearchType”) returns ‘’

Did I miss a step when upgrading ?

GerardOn 2011-03-14 17:50, Gerard FENELON wrote:

Hi

I am experimenting with RT-Extension-MobileUI 1.01 on RT 3.8.8.

I am surprised by the Saved Searches on the home page.
The Home page lists 8 Saved Searches
whereas when I go to the Search Builder I have 13.

I don’t see any commonality between the shown Saved Searches
or between the unshown Saved Searches.
Privacy does not seem to influence this :
I am missing some but not all searches from "My Saved Searches"
and also missing some but not all searches from “MyCompany Everybody’s
saved searches”
(I have a group called “MyCompany Everybody”)

Another of my colleagues sees the same thing :
she sees only 2 searches from the 5 “MyCompany Everybody’s saved
searches”.
(the same as me).
She does not see any searches from her 6 “My Saved Searches”.
She does not see any searches from the 3 with yet another privacy.

Has anyone had a similar issue ?

Regards
Gerard

Apparently for the missing Searches
$search->SubValue(“SearchType”) returns ‘’

Did I miss a step when upgrading ?

Out of curiosity, what version did you upgrade from?
Most code in RT protects against empty SearchTypes, but it sounds
like this code missed it.

Can you resubmit that as a patch so it can be applied to the extension
and to 4.0?

Thanks

-kevin> On 2011-03-14 17:50, Gerard FENELON wrote:

Hi

I am experimenting with RT-Extension-MobileUI 1.01 on RT 3.8.8.

I am surprised by the Saved Searches on the home page.
The Home page lists 8 Saved Searches
whereas when I go to the Search Builder I have 13.

I don’t see any commonality between the shown Saved Searches
or between the unshown Saved Searches.
Privacy does not seem to influence this :
I am missing some but not all searches from "My Saved Searches"
and also missing some but not all searches from “MyCompany
Everybody’s saved searches”
(I have a group called “MyCompany Everybody”)

Another of my colleagues sees the same thing :
she sees only 2 searches from the 5 “MyCompany Everybody’s saved
searches”.
(the same as me).
She does not see any searches from her 6 “My Saved Searches”.
She does not see any searches from the 3 with yet another privacy.

Has anyone had a similar issue ?

Regards
Gerard

Hi Kevin

we started with 3.4.6in 2004
moved to 3.6.10 in December 2009
moved to 3.8.8 in December 2010

I suspect those searches are old, maybe before the move to 3.6.10

I don’t have a patch to submit.
For the moment I just changed
opt/rt3/local/plugins/RT-Extension-MobileUI/html/m/_elements/menu
from
foreach my $search (@searches) {
next unless $search->SubValue(“SearchType”) eq ‘Ticket’;

to
foreach my $search (@searches) {
$RT::Logger->info( “SavedSearched '” . $search->Description,
"’ ‘SearchType’ : ‘" . $search->SubValue(“SearchType”) . "’" );
next unless $search->SubValue(“SearchType”) eq ‘Ticket’;

I found a workaround : renaming the Searches.
Just resaving the Search without changing its name does not seem to be
enough.

Thanks
GerardOn 2011-03-15 14:34, Kevin Falcone wrote:

On Mon, Mar 14, 2011 at 07:59:29PM +0100, Gerard FENELON wrote:

Apparently for the missing Searches
$search->SubValue(“SearchType”) returns ‘’

Did I miss a step when upgrading ?
Out of curiosity, what version did you upgrade from?
Most code in RT protects against empty SearchTypes, but it sounds
like this code missed it.

Can you resubmit that as a patch so it can be applied to the extension
and to 4.0?

Thanks

-kevin

On 2011-03-14 17:50, Gerard FENELON wrote:

Hi

I am experimenting with RT-Extension-MobileUI 1.01 on RT 3.8.8.

I am surprised by the Saved Searches on the home page.
The Home page lists 8 Saved Searches
whereas when I go to the Search Builder I have 13.

I don’t see any commonality between the shown Saved Searches
or between the unshown Saved Searches.
Privacy does not seem to influence this :
I am missing some but not all searches from "My Saved Searches"
and also missing some but not all searches from “MyCompany
Everybody’s saved searches”
(I have a group called “MyCompany Everybody”)

Another of my colleagues sees the same thing :
she sees only 2 searches from the 5 “MyCompany Everybody’s saved
searches”.
(the same as me).
She does not see any searches from her 6 “My Saved Searches”.
She does not see any searches from the 3 with yet another privacy.

Has anyone had a similar issue ?

Regards
Gerard

Hi Kevin

we started with 3.4.6in 2004
moved to 3.6.10 in December 2009
moved to 3.8.8 in December 2010

I suspect those searches are old, maybe before the move to 3.6.10

My guess was going to be that you came up from 3.4, so that ties in
nicely.

I don’t have a patch to submit.
For the moment I just changed
opt/rt3/local/plugins/RT-Extension-MobileUI/html/m/_elements/menu
from
foreach my $search (@searches) {
next unless $search->SubValue(“SearchType”) eq ‘Ticket’;

to
foreach my $search (@searches) {
$RT::Logger->info( “SavedSearched '” . $search->Description,
"’ ‘SearchType’ : ‘" . $search->SubValue(“SearchType”) . "’" );
next unless $search->SubValue(“SearchType”) eq ‘Ticket’;

Does changing that to something like:

     next if $search->SubValue("SearchType") && $search->SubValue("SearchType") ne 'Ticket';

also work?

I found a workaround : renaming the Searches.
Just resaving the Search without changing its name does not seem to
be enough.

Does changing an attribute of the search work? I didn’t want to
suggest resaving because I wasn’t sure it would work.

-kevin

[…]

I don’t have a patch to submit.
For the moment I just changed
opt/rt3/local/plugins/RT-Extension-MobileUI/html/m/_elements/menu
from
foreach my $search (@searches) {
next unless $search->SubValue(“SearchType”) eq ‘Ticket’;
to
foreach my $search (@searches) {
$RT::Logger->info( “SavedSearched '” . $search->Description,
"’ ‘SearchType’ : ‘" . $search->SubValue(“SearchType”) . "’" );
next unless $search->SubValue(“SearchType”) eq ‘Ticket’;
Does changing that to something like:
next if $search->SubValue(“SearchType”)&& $search->SubValue(“SearchType”) ne ‘Ticket’;
also work?

Yes.

As an aside, I am not totally in love with having my 13 Saved Searches
on the home page
I would probably prefer having a link called “Saved Searches” pointing
to another page
and maybe another link to Dashboards (if that is feasible).

I found a workaround : renaming the Searches.
Just resaving the Search without changing its name does not seem to
be enough.
Does changing an attribute of the search work?
I don’t understand what you mean by attribute of the search

I didn’t want to
suggest resaving because I wasn’t sure it would work.

-kevin
Gerard

    next unless $search->SubValue("SearchType") eq 'Ticket';

Does changing that to something like:
next if $search->SubValue(“SearchType”)&& $search->SubValue(“SearchType”) ne ‘Ticket’;
also work?

Yes.

Thanks for testing, the extension and the RT4 implementation will need
to get patched with something along those lines.

As an aside, I am not totally in love with having my 13 Saved
Searches on the home page
I would probably prefer having a link called "Saved Searches"
pointing to another page
and maybe another link to Dashboards (if that is feasible).

I believe this is one of those places where there are lots of opinions
(other people have expressed that they hated having to click to get
their searches, since they always want to get to a particular search
quickly) but patches to make it configurable are welcome.

I found a workaround : renaming the Searches.
Just resaving the Search without changing its name does not seem to
be enough.
Does changing an attribute of the search work?
I don’t understand what you mean by attribute of the search

Adding another search restriction and then saving it (and then you can
go remove that). But the patch should be sufficient to avoid needing
workarounds.

-kevin

Kevin
Thanks for the help.
GerardOn 2011-03-15 16:08, Kevin Falcone wrote:

On Tue, Mar 15, 2011 at 03:53:47PM +0100, Gerard FENELON wrote:

     next unless $search->SubValue("SearchType") eq 'Ticket';

Does changing that to something like:
next if $search->SubValue(“SearchType”)&& $search->SubValue(“SearchType”) ne ‘Ticket’;
also work?
Yes.
Thanks for testing, the extension and the RT4 implementation will need
to get patched with something along those lines
As an aside, I am not totally in love with having my 13 Saved
Searches on the home page
I would probably prefer having a link called "Saved Searches"
pointing to another page
and maybe another link to Dashboards (if that is feasible).
I believe this is one of those places where there are lots of opinions
(other people have expressed that they hated having to click to get
their searches, since they always want to get to a particular search
quickly) but patches to make it configurable are welcome.

I found a workaround : renaming the Searches.
Just resaving the Search without changing its name does not seem to
be enough.
Does changing an attribute of the search work?
I don’t understand what you mean by attribute of the search
Adding another search restriction and then saving it (and then you can
go remove that). But the patch should be sufficient to avoid needing
workarounds.

-kevin