R2815 - in rt/branches/3.4-RELEASE: . html/Ticket lib/RT/Action lib/RT/Interface

RT Developers
1 
  •            $Message->head->replace('References',$old_txn->Message->First->GetHeader('Message-Id'). " ".$old_txn->Message->First->GetHeader('References') );

I think you concatenate the strings in the wrong order. The old
message ID must be appended, not prepended. You also should trim
overlong References: headers (by dropping everything but the first two
and last three message IDs, for example), to work around bugs in
certain Windows clients which would otherwise crash.

I think a way to customize the $pseudo_ref value is desirable.

2 
  •            $Message->head->replace('References',$old_txn->Message->First->GetHeader('Message-Id'). " ".$old_txn->Message->First->GetHeader('References') );

I think you concatenate the strings in the wrong order. The old
message ID must be appended, not prepended.

Nice catch.

You also should trim
overlong References: headers (by dropping everything but the first two
and last three message IDs, for example), to work around bugs in
certain Windows clients which would otherwise crash.

Can you point me at a reference for this?

I think a way to customize the $pseudo_ref value is desirable.

I can see that. I’ll break it out to a separate subroutine.

3

You also should trim
overlong References: headers (by dropping everything but the first two
and last three message IDs, for example), to work around bugs in
certain Windows clients which would otherwise crash.

I’m pretty that’s not how my gnus behaves.

seph

4

  • You also should trim

overlong References: headers (by dropping everything but the first two
and last three message IDs, for example), to work around bugs in
certain Windows clients which would otherwise crash.

I’m pretty that’s not how my gnus behaves.

There’s a function to wrap and shorten references:

| message-shorten-references is a compiled Lisp function in `message’.
| (message-shorten-references HEADER REFERENCES)
|
| Trim REFERENCES to be 21 Message-ID long or less, and fold them.
| When sending via news, also check that the REFERENCES are less
| than 988 characters long, and if they are not, trim them until
| they are.

The code mentions broken INN versions (not everything that’s broken is
Outlook). As in NNTP, there’s the SMTP line limit.

Surely there has to be a Perl module which already deals with the
nitty-gritty details.

5

The code mentions broken INN versions (not everything that’s broken is
Outlook). As in NNTP, there’s the SMTP line limit.

The SMTP line limit is per line, not per header as I read the spec. and
MIME::Tools takes care of folding for you.

6
  • Jesse Vincent:

The code mentions broken INN versions (not everything that’s broken is
Outlook). As in NNTP, there’s the SMTP line limit.

The SMTP line limit is per line, not per header as I read the spec. and
MIME::Tools takes care of folding for you.

Okay, so the current version should be fine. Thanks.