PATCH: silence warnings Ticket/Elements/ShowTransactionAttachments

Attached. Problem was a premature stringification and localization for
display so I separated the display item from the number for later
comparison.

–j
Jim Meyer, Geek at Large jmeyer@dreamworksanimation.com

Ticket.Elements.ShowTransactionAttachments (1.05 KB)

IMHO it’s bug and do remember that I saw patch that fixes bug.
Do you generate patches against 3.4.HEAD or 3.4.4?

PS: size_name is bad name, size_text or size_string is better.On 11/17/05, Jim Meyer purp@acm.org wrote:

Attached. Problem was a premature stringification and localization for
display so I separated the display item from the number for later
comparison.

–j

Jim Meyer, Geek at Large jmeyer@dreamworksanimation.com


Rt-devel mailing list
Rt-devel@lists.bestpractical.com
The rt-devel Archives

Best regards, Ruslan.

Hello!

IMHO it’s bug and do remember that I saw patch that fixes bug.
Do you generate patches against 3.4.HEAD or 3.4.4?

Sorry, I should have said – these patches are all against 3.5.5. If
there’s been a previous bug and patch, please ignore this patch.

PS: size_name is bad name, size_text or size_string is better.

size_string it is. New patch attached.

Cheers!

–j> On 11/17/05, Jim Meyer purp@acm.org wrote:

Attached. Problem was a premature stringification and localization for
display so I separated the display item from the number for later
comparison.

–j

Jim Meyer, Geek at Large jmeyer@dreamworksanimation.com


Rt-devel mailing list
Rt-devel@lists.bestpractical.com
The rt-devel Archives


Best regards, Ruslan.
Jim Meyer, Geek at Large jmeyer@dreamworksanimation.com

Ticket.Elements.ShowTransactionAttachments (1.05 KB)