PATCH: fix for "Modify user rights for queue tasks" screen

RT Users
1

I am a brand new RT user. When I first went to the
http://rt2/Admin/Queues/UserRights.html?id=2 page, I saw the text “(Check box
to revoke right)” and I didn’t understand what I was supposed to do. After
adding some rights, it all made sense.

Here is the patch to only print that line if there are some rights to show. I
think it would be wise to print out something like “No rights assigned to
this user” if possible, too.

The list of possibly-assigned rights seems to be generated on the fly, so why
not only show the rights which could be assigned, shortening the ‘available’
list as the ‘current’ list grows.

This is my first time to see mason code, so I don’t hold any ego to this code
at all. :slight_smile: I love the way it prints errors to the browser.

rob

— SelectRights Thu Feb 7 10:20:28 2002
+++ SelectRights.original Thu Feb 7 10:03:19 2002
@@ -13,16 +13,12 @@

Current rights

-% my ($revoke_already_printed); +(Check box to revoke right)
% while (my $right = $ACLObj->Next()) { % if ($right->RightName) { -% if ($revoke_already_printed != 1) { -(Check box to revoke right)
-% $revoke_already_printed = 1; -% } <%$right->RightNa me%>
% } -% } +% }
2

Here is the patch to only print that line if there are some rights to show. I
think it would be wise to print out something like “No rights assigned to
this user” if possible, too.

For future reference, rt-devel@lists.fsck.com likes patches and things.
To keep Jesse happy, you probably also want to say which version your
patch is applicable against in the master CVS tree (see
http://www.fsck.com/rtfm/ and search for CVS). Admittedly, I don’t follow
these guidelines myself :wink:

Regards,

                         Bruce Campbell                            RIPE
               Systems/Network Engineer                             NCC
             www.ripe.net - PGP562C8B1B                      Operations
3

Here is the patch to only print that line if there are some rights to
show. I
think it would be wise to print out something like “No rights assigned to
this user” if possible, too.

For future reference, rt-devel@lists.fsck.com likes patches and things.

Ahh, the -devel list. :slight_smile:

To keep Jesse happy, you probably also want to say which version your
patch is applicable against in the master CVS tree (see
http://www.fsck.com/rtfm/ and search for CVS). Admittedly, I don’t follow
these guidelines myself :wink:

Um, yeah, my bad. I didn’t use CVS, this was against 2-0-11.

rob