Ok. Now that I understand what it’s doing, the patch makes me twitch.
This is making an already complex API really intensely painful and
magical. Magic variable values just don’t belong there. A more
reasonable solution might be allowing you to call NewAlias ahead of
time, get the second Alias, pass it in as ALIAS2 and have the right
things happen to the query.On Aug 15, 2006, at 11:04 PM, Todd Chapman wrote:
On Tue, Aug 15, 2006 at 10:48:23PM -0400, Jesse Vincent wrote:
On Tue, Aug 15, 2006 at 10:37:50PM -0400, Todd Chapman wrote:
This patch for DBIx::SB allows you to do a LEFT JOIN with
an EXPRESSION and allow you to refer to the alias that
is created in the expression. ( SB requires a TABLE2
argument when doing a LEFT join. )
Tests added. All tests pass.
It looks like you’ve added a new API. If so, you probably need to add
docs for it
(I’d take the cleanup refactoring on its own
Updated patch attached and submitted.
PGP.sig (186 Bytes)