After one day of docs reading, I am proud to send to the list my first diff
As I don’t fully understand everything I did, I welcome all reviews and
comments about what I’ve done wrong here and how it should have been done
instead. I am not at all an HTML, Perl, Mason or RT guru.
The goal :
On the dependencies side of the ticket display page, links are all to
http://your.rt.com/Ticket/Display.html?id=xxxx, wether the ticket is a
standard ticket or an approval. When the ticket is an approval, you are then
not redirected to the proper page to approve or reject the ticket, the url
should read http://your.rt.com/Approvals/Display.html?id=xxxx.
The patch to fsck_com_rt.pm attached corrects this.
I noticed that the ticket “type” is either “ticket” or “Approval” (note the
upercase “A” and lowercase “t”)
Also, the URL is “/Ticket/” or “/Approvals/” (singular and plural).
These are really minor details.
The risks :
I have no idea what else I may have broken with my code… my RT instance
I suspect some performance issues : I feel I access the database to load
tickets when they had already been loaded earlier in the process of
converting Ids to urls. If this is the case, I am wasting resources.
fsck_com_rt.pm.diff (943 Bytes)