Maybe duplicate user preference

Hi,

maybe I found an duplicate user preference where one of them isn’t working.

Under Prefs/Other.html (Logged in as … -> Settings -> Options) you can
set “Number of search results”. As the section is called “RT at a
glance” I would expect to set here the Rows option of the “RT at a
glance” portlets. But changing this option doesn’t work with RT 4.0.7.
This sets the preference “DefaultSummaryRows” defined in
lib/RT/Config.pm. This is the sub value “DefaultSummaryRows” of the
"Pref-RT::System-1" user attribute.

Under Prefs/MyRT.html (Logged in as … -> Settings -> RT at a glance)
there is an “Rows per box” option. If I change this value the displayed
Rows of the “RT at a glance” portlets change to this value.
This sets the preference “SummaryRows” which isn’t defined in
lib/RT/Config.pm. This is the user attribute “Pref-SummaryRows”.

Chris

Hi,

maybe I found an duplicate user preference where one of them isn’t working.

Under Prefs/Other.html (Logged in as … → Settings → Options) you can
set “Number of search results”. As the section is called “RT at a
glance” I would expect to set here the Rows option of the “RT at a
glance” portlets. But changing this option doesn’t work with RT 4.0.7.
This sets the preference “DefaultSummaryRows” defined in
lib/RT/Config.pm. This is the sub value “DefaultSummaryRows” of the
“Pref-RT::System-1” user attribute.

Under Prefs/MyRT.html (Logged in as … → Settings → RT at a glance)
there is an “Rows per box” option. If I change this value the displayed
Rows of the “RT at a glance” portlets change to this value.
This sets the preference “SummaryRows” which isn’t defined in
lib/RT/Config.pm. This is the user attribute “Pref-SummaryRows”.

You are right. DefaultSummaryRows from config was marked as overridable,
but code was never converted to use config based preference. Alex spotted
this recently and pushed a branch that just unmarks the option as overridable.
This is a simple fix for 4.0.

Chris

We’re hiring! Careers — Best Practical Solutions

Best regards, Ruslan.

Thanks.
I commented on Alex commit if it would be better to stay with the config
based preferences.

https://github.com/bestpractical/rt/commit/82c5217Am 06.12.2012 12:59, schrieb Ruslan Zakirov:

You are right. DefaultSummaryRows from config was marked as overridable,
but code was never converted to use config based preference. Alex spotted
this recently and pushed a branch that just unmarks the option as overridable.
This is a simple fix for 4.0.

Thanks.
I commented on Alex commit if it would be better to stay with the config
based preferences.

Remove unimplemented user override of DefaultSummaryRows · bestpractical/rt@82c5217 · GitHub

Alex’s solution for sure goes into 4.0.

For 4.2 we can include config based solution, but it’s not on top of our list.

Am 06.12.2012 12:59, schrieb Ruslan Zakirov:

You are right. DefaultSummaryRows from config was marked as overridable,
but code was never converted to use config based preference. Alex spotted
this recently and pushed a branch that just unmarks the option as overridable.
This is a simple fix for 4.0.


We’re hiring! Careers — Best Practical Solutions

Best regards, Ruslan.