Logic bug in bin/fastcgi_server; allow use of --port

Patch below (against 3.8-trunk) fixes bin/fastcgi_server --port .
Without this, it always listens on $RT::VarPath/fastcgi.sock.

Regards,
Tom

bin/fastcgi_server.in | 2 ±
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/bin/fastcgi_server.in b/bin/fastcgi_server.in
index bf3fdcc…63df548 100644
— a/bin/fastcgi_server.in
+++ b/bin/fastcgi_server.in
@@ -198,7 +198,7 @@ $ENV{‘RT_WEBMUX_HEAVY_LOAD’} = 1;
use File::Basename;
require (dirname(FILE) .’/webmux.pl’);

-unless ( $opt{‘socket’} && $opt{‘port’} ) {
+unless ( $opt{‘socket’} || $opt{‘port’} ) {
require File::Spec;
$opt{‘socket’} = File::Spec->catfile($RT::VarPath, ‘fastcgi.sock’);
}
1.7.2.1

Thanks. Applied for 3.9.On Fri 27.Aug’10 at 20:58:07 +0930, Tom Lanyon wrote:

Patch below (against 3.8-trunk) fixes bin/fastcgi_server --port .
Without this, it always listens on $RT::VarPath/fastcgi.sock.

Regards,
Tom


bin/fastcgi_server.in | 2 ±
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/bin/fastcgi_server.in b/bin/fastcgi_server.in
index bf3fdcc…63df548 100644
— a/bin/fastcgi_server.in
+++ b/bin/fastcgi_server.in
@@ -198,7 +198,7 @@ $ENV{‘RT_WEBMUX_HEAVY_LOAD’} = 1;
use File::Basename;
require (dirname(FILE) .’/webmux.pl’);

-unless ( $opt{‘socket’} && $opt{‘port’} ) {
+unless ( $opt{‘socket’} || $opt{‘port’} ) {
require File::Spec;
$opt{‘socket’} = File::Spec->catfile($RT::VarPath, ‘fastcgi.sock’);
}

1.7.2.1


List info: http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel