Inconsistent behavior between SelfService and Priveledged view

Hi,
In RT 3.4.1, a priveledged user that does not have ModifySelf
doesn’t have a ‘Preferences’ tab in their web interface,
However a non-priveledged user looking at SelfService still
sees a Preferences tab, but obviously gets a Permission Denied if s/he
tries to change anything.
Would you all care for a patch to fix this? Thanks for all the
great work.

Regards,
Erek Dyskant
Server Administrator
Blumenthals.com

Hi,
In RT 3.4.1, a priveledged user that does not have ModifySelf
doesn’t have a ‘Preferences’ tab in their web interface,
However a non-priveledged user looking at SelfService still
sees a Preferences tab, but obviously gets a Permission Denied if s/he
tries to change anything.
Would you all care for a patch to fix this? Thanks for all the
great work.

Sure. That’d be great. Thanks.

Apply to share/html/SelfService/Elements/Tabs

Tested on Fedora Core2, but I’m sure it’ll work on any supported platform

Thanks again for a great product.

Regards,
Erek Dyskant

— Tabs.pristine 2005-05-01 16:18:22.212069432 -0400
+++ Tabs 2005-05-01 16:16:57.464952952 -0400
@@ -68,11 +68,15 @@
},
C => { title => loc(‘New ticket’),
path => ‘SelfService/CreateTicketInQueue.html’

  •                },
    
  •         Z => { title => loc('Preferences'),
    
  •                path => 'SelfService/Prefs.html'
                   }
          };
    

+if ($session{‘CurrentUser’}->HasRight( Right => ‘ModifySelf’,

  •   		       Object => $RT::System )) {
    
  • $tabs->{Z} = { title => loc(‘Preferences’),
  •          path => 'SelfService/Prefs.html'
    
  •          };
    

+}
my $actions = {
B => { html => $m->scomp(‘GotoTicket’)
}On Sun, May 01, 2005 at 12:37:03PM -0400, Jesse Vincent wrote:

On Sun, May 01, 2005 at 09:21:21AM -0600, Erek Dyskant wrote:

Hi,
In RT 3.4.1, a priveledged user that does not have ModifySelf
doesn’t have a ‘Preferences’ tab in their web interface,
However a non-priveledged user looking at SelfService still
sees a Preferences tab, but obviously gets a Permission Denied if s/he
tries to change anything.
Would you all like a patch to fix this? Thanks for all the
great work.

Sure. That’d be great. Thanks.

Regards,
Erek Dyskant
Server Administrator
Blumenthals.com


Rt-devel mailing list
Rt-devel@lists.bestpractical.com
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-devel

tabs.patch (702 Bytes)

Apply to share/html/SelfService/Elements/Tabs

Thanks again for a great product.

Thanks. Applied.