GUI improvement

Hello people!

First of all, I’m in RT 3.0.10 and RTIR 1.0.5

I’ve added a line in /RTIR/Display.html file, because:
after the creation of a ticket, the URL still keep as
http:…/RTIR/Create.html
so, an accidental reload click in the navigator creates a new incident
ticket

This is my diff:
— Display.html.old Tue Mar 30 03:56:34 2004
+++ Display.html Wed May 26 13:55:48 2004
@@ -281,6 +281,7 @@
$ARGS{‘id’}=$Ticket->Id;
&$DoLinks($ChildObj, $Ticket);
}

  • $m->redirect(‘Display.html’.’?id=’.$ARGS{‘id’});

} else {
$Ticket = LoadTicket($id);

What do you think about?

Besides, a month ago I’ve send a mail at RT-Develop List asking about
another little change
http://lists.bestpractical.com/pipermail/rt-devel/2004-April/005743.html
Somebody know if my change is right?

Thanks a lot,

Marc

Marc Boix i Ricart
Dept. de Comunicacions
E-mail: mboix@cesca.es
Tf: 93 205.64.64 - ext 4454
CESCA (Centre de Supercomputaci� de Catalunya)
http://www.cesca.es

Marc Boix wrote:

Hello people!

Hi Marc

I’ve added a line in /RTIR/Display.html file, because:
after the creation of a ticket, the URL still keep as
http:…/RTIR/Create.html
so, an accidental reload click in the navigator creates a new incident
ticket

This is my diff:
— Display.html.old Tue Mar 30 03:56:34 2004
+++ Display.html Wed May 26 13:55:48 2004
@@ -281,6 +281,7 @@
$ARGS{‘id’}=$Ticket->Id;
&$DoLinks($ChildObj, $Ticket);
}

  • $m->redirect(‘Display.html’.’?id=’.$ARGS{‘id’});

} else {
$Ticket = LoadTicket($id);

What do you think about?

Looks okay and I can’t see any reason why this shouldn’t be merged with
RTIR trunk. Jesse?

Besides, a month ago I’ve send a mail at RT-Develop List asking about
another little change
http://lists.bestpractical.com/pipermail/rt-devel/2004-April/005743.html
Somebody know if my change is right?

Again, this looks fine.

Unfortunately I don’t have time to test these for a few weeks as I’ll be
on holiday.

Cheers
John
JANET-CERT

The problem with using redirects here is that RT depends on H?TML::Mason
to do the redirect like that. And the last time we tested, mod_perl2
redirect support in mason was broken, leading to much screaming from end
users. Once mod_perl 2.0 is release and mason supports it fully, this
should be just fine. Open a ticket?On Fri, May 28, 2004 at 08:35:12AM +0100, John Green wrote:

Marc Boix wrote:

Hello people!

Hi Marc

I’ve added a line in /RTIR/Display.html file, because:
after the creation of a ticket, the URL still keep as
http:…/RTIR/Create.html
so, an accidental reload click in the navigator creates a new incident
ticket

This is my diff:
— Display.html.old Tue Mar 30 03:56:34 2004
+++ Display.html Wed May 26 13:55:48 2004
@@ -281,6 +281,7 @@
$ARGS{‘id’}=$Ticket->Id;
&$DoLinks($ChildObj, $Ticket);
}

  • $m->redirect(‘Display.html’.’?id=’.$ARGS{‘id’});

} else {
$Ticket = LoadTicket($id);

What do you think about?

Looks okay and I can’t see any reason why this shouldn’t be merged with
RTIR trunk. Jesse?

Besides, a month ago I’ve send a mail at RT-Develop List asking about
another little change
http://lists.bestpractical.com/pipermail/rt-devel/2004-April/005743.html
Somebody know if my change is right?

Again, this looks fine.

Unfortunately I don’t have time to test these for a few weeks as I’ll be
on holiday.

Cheers
John
JANET-CERT


Rtir mailing list
Rtir@lists.bestpractical.com
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rtir