trying to resolve the following tickets, I did a first “rewrite” of RT
css/html. Goal was also to remove absolute/fixed positionning in favour
of dynamic positionning (using floats).
12437: problem with #topactions in konqueror
6823: try to make proper xhtml
12770: #nav in konqueror > 4
10079: display problem when $Showbar = 0
here is some comments of my work:
tools in search results was not using $actions, but wrote ul/li itself
with bad positionning, so I moved it to an update of $actions in
Ticket/Elements/Tab
12770: was just a problem with the three “empty”
used between
and
which is not allowed, I just removed them with no side
effect it seems
there was some curious ordering in html between page-navigation, nav,
header and quickbar, I moved them to have a simple layout: a top
"quickbar", a left “nav”, a right “page” (new div, which contains
topactions, then page-navigation, then body) and a footer
I don’t think RT can be used without scrolling under less than
1024x768 screens, so I added a min-width of 76em to body to avoid
"page" to go down “nav” in case of overflow
I leave the title (mostly ticket subject) in topactions to wrap and so
use two lines if necessary, this makes the navigation bar to go down if
needed, but seems far better to me than truncated subjects
I tested this with:
ie6 win$
ie7 win$
ff2 win$
safari win$
ff3 GNU/Linux
konqueror 4 GNU/Linux
12437, 12770 and 10079 seems resolved with this, there doesn’t seems to
be major issues (doesn’t looks worse than actually ;)).
Can you test this then report any major regression (with screenshots
and navigator version) before I commit this?
I now there is still some little bugs (mostly with ie6 :() and other
thinks I want to enhance, But I’m tired and prefer to commit this as
soon as possible and fix remaining issues one by one
PS: attached, test2.html which is the minimal layout I wanted to apply
on RT.
trying to resolve the following tickets, I did a first “rewrite” of RT
css/html. Goal was also to remove absolute/fixed positionning in favour
of dynamic positionning (using floats).
12437: problem with #topactions in konqueror
6823: try to make proper xhtml
12770: #nav in konqueror > 4
10079: display problem when $Showbar = 0
here is some comments of my work:
tools in search results was not using $actions, but wrote ul/li itself
with bad positionning, so I moved it to an update of $actions in
Ticket/Elements/Tab
Not sure. Should look at it. May be it’s related to 3.5 style.
12770: was just a problem with the three “empty”
used between
and
which is not allowed, I just removed them with no side
effect it seems
This can go.
there was some curious ordering in html between page-navigation, nav,
header and quickbar, I moved them to have a simple layout: a top
“quickbar”, a left “nav”, a right “page” (new div, which contains
topactions, then page-navigation, then body) and a footer
Jesse knowns this better.
I don’t think RT can be used without scrolling under less than
1024x768 screens, so I added a min-width of 76em to body to avoid
“page” to go down “nav” in case of overflow
Is it web2.0 only?
I leave the title (mostly ticket subject) in topactions to wrap and so
use two lines if necessary, this makes the navigation bar to go down if
needed, but seems far better to me than truncated subjects
I’m ok.
Anyway, should try with localized version. Russian is often wider a little.
I tested this with:
ie6 win$
ie7 win$
ff2 win$
safari win$
ff3 GNU/Linux
konqueror 4 GNU/Linux
12437, 12770 and 10079 seems resolved with this, there doesn’t seems to
be major issues (doesn’t looks worse than actually ;)).
Can you test this then report any major regression (with screenshots
and navigator version) before I commit this?
I now there is still some little bugs (mostly with ie6 :() and other
thinks I want to enhance, But I’m tired and prefer to commit this as
soon as possible and fix remaining issues one by one
If it’s improvement and as we’re in earlier 3.8.3 stage then may be it
should go in (if other developers agree).
PS: attached, test2.html which is the minimal layout I wanted to apply
on RT.
Thank you so much for all this hacking. I’d very much like to see this
get into RT. Until it’s settled and IE 6 is happy, it probably makes
sense to do the work on a feature branch, just so as to not destabilize
others or cause you to block the release or a release to block you.
Once it’s checked into a branch, I’m happy to try it out on rt3.fsck.com
tools in search results was not using $actions, but wrote ul/li itself
with bad positionning, so I moved it to an update of $actions in
Ticket/Elements/Tab
Not sure. Should look at it. May be it’s related to 3.5 style.
Well I must admit, that I didn’t touch the 3.5 style. It’s already a lot
of work to have one working style We can try to adapt it once web2
modification are validated.
I don’t think RT can be used without scrolling under less than
1024x768 screens, so I added a min-width of 76em to body to avoid
“page” to go down “nav” in case of overflow
Is it web2.0 only?
Sorry I don’t understand your question here.
Anyway, should try with localized version. Russian is often wider a little.
Thank you so much for all this hacking. I’d very much like to see this
get into RT. Until it’s settled and IE 6 is happy, it probably makes
sense to do the work on a feature branch, just so as to not destabilize
others or cause you to block the release or a release to block you.
Once it’s checked into a branch, I’m happy to try it out on rt3.fsck.com
Is that reasonable?
Sure, and this way I can this remaining bugs before merge in trunk.
tools in search results was not using $actions, but wrote ul/li itself
with bad positionning, so I moved it to an update of $actions in
Ticket/Elements/Tab
Not sure. Should look at it. May be it’s related to 3.5 style.
Well I must admit, that I didn’t touch the 3.5 style. It’s already a lot
of work to have one working style We can try to adapt it once web2
modification are validated.
The existing styles should work at least as well as they currently do
before this goes into trunk. There are organizations that depend on the
older styles to be able to run RT 3.8. (So they don’t need to retrain /
redo documentation). And the point of CSS is that it’s at least supposed
to be possible to retheme without changing the raw html.
But yes, doing 3.5 and 3.4 compat stylesheets (and maybe giving them
names once the current main theme is done makes sense.
How important is IE6 support anymore. For our environment all the people
who need to use RT we can force to use whatever browser and we are not
locked to MS/IE at all. So it’s possible I can’t relate to bigger
organizations requirements. Life without IE6 or lower is just so much
easier…
