Comments get posted twice due to Jumbo interface

Hi

one of my user reported the following issue :

When I make changes to an RT using "Jumbo",
then after I hit save changes the Jumbo page is presented again.
This is okay.

The problem is that the comment field is not cleared.
So if I make some unrelated change and forget to clear the comments myself,
they will get reposted.

I am able to reproduce it and before diving into the code,
I would like to know whether it is a known issue, hopefully with a known
solution ?
Or is there something wrong in my config (we are using 3.8.8) ?

Thanks
Gerard

Hi

one of my user reported the following issue :

When I make changes to an RT using “Jumbo”,
then after I hit save changes the Jumbo page is presented again.
This is okay.

The problem is that the comment field is not cleared.
So if I make some unrelated change and forget to clear the comments myself,
they will get reposted.

I am able to reproduce it and before diving into the code,
I would like to know whether it is a known issue, hopefully with a known solution ?
Or is there something wrong in my config (we are using 3.8.8) ?

If you can confirm this on 3.8.9, please file a bug in the bugtracker.

-kevin

Hi,

Fixed on 4.0/clean_jumbo_message_box. Not sure where it ends up. It’s
been this way for ages.On Thu, Feb 24, 2011 at 6:20 PM, Kevin Falcone falcone@bestpractical.com wrote:

On Thu, Feb 24, 2011 at 02:44:47PM +0100, Gerard FENELON wrote:

Hi

one of my user reported the following issue :

When I make changes to an RT using “Jumbo”,
then after I hit save changes the Jumbo page is presented again.
This is okay.

The problem is that the comment field is not cleared.
So if I make some unrelated change and forget to clear the comments myself,
they will get reposted.

I am able to reproduce it and before diving into the code,
I would like to know whether it is a known issue, hopefully with a known solution ?
Or is there something wrong in my config (we are using 3.8.8) ?

If you can confirm this on 3.8.9, please file a bug in the bugtracker.

-kevin

Best regards, Ruslan.

Thanks Ruslan
Do you think I could backport that fix to 3.6.8/3.6.9 ?
GerardOn 2011-03-02 12:56, Ruslan Zakirov wrote:

Hi,

Fixed on 4.0/clean_jumbo_message_box. Not sure where it ends up. It’s
been this way for ages.

On Thu, Feb 24, 2011 at 6:20 PM, Kevin Falcone wrote:

On Thu, Feb 24, 2011 at 02:44:47PM +0100, Gerard FENELON wrote:

Hi

one of my user reported the following issue :

When I make changes to an RT using “Jumbo”,
then after I hit save changes the Jumbo page is presented again.
This is okay.

The problem is that the comment field is not cleared.
So if I make some unrelated change and forget to clear the comments myself,
they will get reposted.

I am able to reproduce it and before diving into the code,
I would like to know whether it is a known issue, hopefully with a known solution ?
Or is there something wrong in my config (we are using 3.8.8) ?

If you can confirm this on 3.8.9, please file a bug in the bugtracker.

-kevin

Thanks Ruslan
Do you think I could backport that fix to 3.6.8/3.6.9 ?

You can try git rebase --onto with that branch, but I believe it uses
a method that didn’t exist until 4.0.0rc1 so you’ll need to fix it to
use the older style component redirect instead.

-kevin> On 2011-03-02 12:56, Ruslan Zakirov wrote:

Hi,

Fixed on 4.0/clean_jumbo_message_box. Not sure where it ends up. It’s
been this way for ages.

On Thu, Feb 24, 2011 at 6:20 PM, Kevin Falcone wrote:

On Thu, Feb 24, 2011 at 02:44:47PM +0100, Gerard FENELON wrote:

Hi

one of my user reported the following issue :

When I make changes to an RT using “Jumbo”,
then after I hit save changes the Jumbo page is presented again.
This is okay.

The problem is that the comment field is not cleared.
So if I make some unrelated change and forget to clear the comments myself,
they will get reposted.

I am able to reproduce it and before diving into the code,
I would like to know whether it is a known issue, hopefully with a known solution ?
Or is there something wrong in my config (we are using 3.8.8) ?
If you can confirm this on 3.8.9, please file a bug in the bugtracker.

-kevin