RL> Well, your “much better” example will break the MTA. 
That’s not an
RL> email address in front, it’s a realname. (It will also break with
RL> commas, etc.)
Well, no, it won’t make a bit of difference given the way it is quoted
now. The realname part is outside of a quoted environment.
Yep, it will. Try a realname with an email address and a comma – or
worse, with a lone double-quote in it. I’ve no idea what a “quoted
environment” is in an address, and neither does 2822, so I don’t know
what the last sentence means.
But yes, the way that it is quoted now also breaks. But the idea of
fixing it is to make it work, not make it break differently.
You can either evaluate whether or not it needs to be quoted, or you
can blindly quote. Blindly quote is easier, so there it is. Of course,
no-one is forcing you to apply it – if you think it should be done
some other way, you’re welcome to write that instead.
(I find addr (name)'' to be ugly compared to name
‘’. Important things go first if you read left to right.)
btw: your patch doesn’t apply to 2.0.14 cleanly.
Quite possibly, but the changes are trivial – try using vpatch
instead. It’s only five new lines, and only three of them are
code.
One thing I forgot to mention (thanks, Jesse is that my patch
doesn’t make things prettier for addresses already in the database
that have quotes around them, although it guarantees they’ll be legal.
I also removed all of the quotes around addresses in the DB when I
applied it.
-Rich
Rich Lafferty --------------±----------------------------------------------
Ottawa, Ontario, Canada | Save the Pacific Northwest Tree Octopus!
http://www.lafferty.ca/ | Save The Pacific Northwest Tree Octopus
rich@lafferty.ca -----------±----------------------------------------------