Approval notification

Hello,

I set up a “Create Tickets” script, and the approval ticket is created, but
no emails is ever sent to the approvers.

I tracked down in RT::Approval::Rule::NewPending, in commit, this code:

# first txn entry of the approval ticket
local $self->{TransactionObj} = $to;
$self->RunScripAction('Notify Owner', 'New Pending Approval', @_);

return;

# this generates more correct content of the message, but not sure
# if ccmessageto is the right way to do this.
my $template = $self->GetTemplate('New Pending Approval',
                                  TicketObj => $top,
                                  TransactionObj => $to)
    or return;

Was the “return” in the middle left there by mistake? No email is ever sent
since there is no owner, just a few AdminCC.

Thanks

Mathieu Longtin
1-514-803-8977

Hello,

I set up a “Create Tickets” script, and the approval ticket is created, but
no emails is ever sent to the approvers.

I bounced your mail into the bug tracker and asked the developer
responsible for the code to comment.

-kevin

I changed “Notify Owner” to “Notify AdminCCs”, that seemed to fix it.

I’m noticing that the whole Approval thing is kind of clunky.

Another problem I encountered:
When a member of a group approves of a ticket, the owner is not changed, so
the email looks like “Ticket approved by Nobody”.

The whole Ruleset thing is kind of nice though, it makes it easy to code
some extensions that involve scrip functionality without inserting scrips
all over the place.

Mathieu Longtin
1-514-803-8977On Wed, Oct 14, 2009 at 2:43 PM, Mathieu Longtin mathieu@closetwork.orgwrote:

Hello,

I set up a “Create Tickets” script, and the approval ticket is created, but
no emails is ever sent to the approvers.

I tracked down in RT::Approval::Rule::NewPending, in commit, this code:

# first txn entry of the approval ticket
local $self->{TransactionObj} = $to;
$self->RunScripAction('Notify Owner', 'New Pending Approval', @_);

return;

# this generates more correct content of the message, but not sure
# if ccmessageto is the right way to do this.
my $template = $self->GetTemplate('New Pending Approval',
                                  TicketObj => $top,
                                  TransactionObj => $to)
    or return;

Was the “return” in the middle left there by mistake? No email is ever sent
since there is no owner, just a few AdminCC.

Thanks


Mathieu Longtin
1-514-803-8977