ShowHistory Modification to show last communication

After playing with a mod that was posted to this file earlier, I found
that often the last item in a history list was only a status change
message. After fielding a few confused developers’ requests, I added
some code to find the last communication in a transaction list.

I’ve posted the whole file below - if you drop this in
rt3/local/html/Ticket/Elements it will cause only the last communication
to appear when a ticket summary is displayed, and the whole histry when
they click the ‘History’ link.

%# BEGIN LICENSE BLOCK
%#%# Copyright (c) 1996-2003 Jesse Vincent jesse@bestpractical.com
%#
%# (Except where explictly superceded by other copyright notices)
%#
%# This work is made available to you under the terms of Version 2 of
%# the GNU General Public License. A copy of that license should have
%# been provided with this software, but in any event can be snarfed
%# from www.gnu.org.
%#
%# This work is distributed in the hope that it will be useful, but
%# WITHOUT ANY WARRANTY; without even the implied warranty of
%# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
%# General Public License for more details.
%#
%# Unless otherwise specified, all modifications, corrections or
%# extensions to this work which alter its source code become the
%# property of Best Practical Solutions, LLC when submitted for
%# inclusion in the work.
%#
%#
%# END LICENSE BLOCK
<%perl>

Returns the last communication transaction in the passed

Transactions list
sub show_last_communication {
my ($list) = @_;
my ($picked);

while (my $Transaction = $list->Next) {
$picked = $Transaction if ( $Transaction->Type =~
m/(Create)|(Correspond)|(Comment)/ );
}

return $picked;
}

if ($ShowDisplayModes or $ShowTitle) {
my $title;
my $titleright;
if ($ShowTitle) {
$title = loc(‘History’);
}
else {
$title = ’ ';
}
$titleright = loc(‘Display mode’) . “:”;
if ($ShowHeaders && $ShowHeaders == $Ticket->Id ) {
$titleright .= “[<A HREF="” . $URIFile . “?id=”
. $Ticket->id . “">”
. loc(“Brief headers”)
. “] [”
. loc(“Full headers”) . “]
”;
}
else {
$titleright .= “[”
. loc(“Brief headers”)
. “]
[<A HREF="”
. $URIFile
. “?ShowHeaders=”
. $Ticket->Id . “&id=”
. $Ticket->id . “">”
. loc(“Full headers”) . “]”;
}
</%perl>
<& /Elements/TitleBoxStart, title => $title, titleright => $titleright,
bodyclass=> ‘’&>
% }

% if ($m->request_comp()->title=~/Ticket\/Display\.html/) { % my $Transaction = show_last_communication($Transactions); <& ShowTransaction, Ticket => $Ticket, Transaction => $Transaction, ShowHeaders => $ShowHeaders, Collapsed => $Collapsed, RowNum => $i, ShowTitleBarCommands => $ShowTitleBarCommands &>

% } else {
% while (my $Transaction = $Transactions->Next) {
% my $skip = 0;
% $m->comp(‘/Elements/Callback’, _CallbackName => ‘SkipTransaction’,
Transaction => $Transaction, skip => $skip, %ARGS);
% next if $skip;
% $i++;
% if ($Transactions->IsLast) {

% }
<& ShowTransaction, Ticket => $Ticket, Transaction =>
$Transaction, ShowHeaders => $ShowHeaders, Collapsed => $Collapsed,
RowNum => $i, ShowTitleBarCommands => $ShowTitleBarCommands &>
% }
% }

% if ($ShowDisplayModes or $ShowTitle) { <& /Elements/TitleBoxEnd &> % }

<%INIT>

my $Transactions = $Ticket->Transactions;
my $i;

</%INIT>
<%ARGS>
$URIFile => ‘Display.html’
$Ticket => undef
$ShowHeaders => undef
$Collapsed => undef
$ShowTitle => 1
$ShowDisplayModes => 1
$ShowTitleBarCommands => 1
</%ARGS>

David Swift wrote:

After playing with a mod that was posted to this file earlier, I found
that often the last item in a history list was only a status change
message. After fielding a few confused developers’ requests, I added
some code to find the last communication in a transaction list.

I have modified David’s code to

  • display the first and last comment
  • display appropriate titles

Install in rt3/local/html/Ticket/Elements.

Mike

ShowHistory.gz (1.53 KB)

Sorry, there was a defect in the code I posted earlier
such that an error was displayed if there was only one
comment. The attached code fixes the defect.

ShowHistory.gz (1.54 KB)