Shouldn't LocalBase and LocalTarget be zero for non-Ticket objects?

RT::Link->Create only checks if the Base/Target IsLocal
before setting LocalBase/LocalTarget. Shouldn’t it also
make sure that the object ISA RT::Ticket?

-Todd

RT::Link->Create only checks if the Base/Target IsLocal
before setting LocalBase/LocalTarget. Shouldn’t it also
make sure that the object ISA RT::Ticket?

Yes.

RT::Link->Create only checks if the Base/Target IsLocal
before setting LocalBase/LocalTarget. Shouldn’t it also
make sure that the object ISA RT::Ticket?

Yes.

Attached patch and additional tests. Bcc to rt-bugs.

All related tests pass. Some 3.5 tests doen’t pass but
I think that is expected. Test files that don’t pass:

Failed Test Stat Wstat Total Fail Failed List of Failed
lib/t/regression/12-search.t 11 2816 39 11 28.21% 18-19 21-22
32-33 35-39
lib/t/regression/20-sort-by-reque 2 512 55 2 3.64% 54-55

-Todd

LinkLocal.patch (3.92 KB)