RT 4.4.0 ShowHistory -> Scroll problem with French GUI

Hi,

I’m using RT 4.4.0 on a PostgreSQL 9.3 database.

Today I activated the option
Set($ShowHistory, ‘scroll’);

And I ran into a problem with users with French GUI.
When you open a ticket, you should first see “Ticket metadata” and "history"
On the French users, the history is not shown.
When changing the users language or disabling this option, everything works fine.

Is there somebody with the same problem?

Best Regards
Bernhard

Le 14/06/2016 � 13:53, Eierschmalz, Bernhard a �crit :

Hi,

I�m using RT 4.4.0 on a PostgreSQL 9.3 database.

Today I activated the option

Set($ShowHistory, �scroll�);

And I ran into a problem with users with French GUI.

When you open a ticket, you should first see �Ticket metadata� and �history�

On the French users, the history is not shown.

I confirm that it’s broken and proposed a fix here:
https://issues.bestpractical.com/Ticket/Display.html?id=32090

Hi Guys,

Thanks for the fix, Emmanuel. We ended up doing it a little differently though with the JS I18N engine. You can see the branch 4.4/fix-history-scroll-js for the details. We are planning on merging the fix into 4.4.1.

Bernhard, attached is a patch for 4.4.0 that should fix the problem. Let me know if you have any trouble with it.

Thank you,
Dustin> On Jun 16, 2016, at 4:05 AM, Emmanuel Lacour elacour@easter-eggs.com wrote:

Le 14/06/2016 à 13:53, Eierschmalz, Bernhard a écrit :

Hi,

I’m using RT 4.4.0 on a PostgreSQL 9.3 database.

Today I activated the option

Set($ShowHistory, ‘scroll’);

And I ran into a problem with users with French GUI.

When you open a ticket, you should first see “Ticket metadata” and “history”

On the French users, the history is not shown.

I confirm that it’s broken and proposed a fix here:
https://issues.bestpractical.com/Ticket/Display.html?id=32090 https://issues.bestpractical.com/Ticket/Display.html?id=32090


RT 4.4 and RTIR Training Sessions https://bestpractical.com/training https://bestpractical.com/training

  • Los Angeles - September, 2016

fix-history-scroll-js-4.4.0.patch (2.27 KB)

signature.asc (801 Bytes)

Le 16/06/2016 � 19:54, Dustin Graves a �crit :

Hi Guys,

Thanks for the fix, Emmanuel. We ended up doing it a little differently
though with the JS I18N engine. You can see the
branch 4.4/fix-history-scroll-js for the details. We are planning on
merging the fix into 4.4.1.

nice :slight_smile:

(I lack JS knowledge :()

Do you think you have time to review some of my latest small patches
before 4.4.1:

https://issues.bestpractical.com/Search/Results.html?Format='+++<b><a+href%3D"%2FTicket%2FDisplay.html%3Fid%3D__id__">__id__<%2Fa><%2Fb>%2FTITLE%3A%23'%2C '<b><a+href%3D"%2FTicket%2FDisplay.html%3Fid%3D__id__">__Subject__<%2Fa><%2Fb>%2FTITLE%3ASubject'&Order=ASC|ASC|ASC|ASC&OrderBy=id|||&Page=&Query=Status+%3D+'in-review'+AND+Requestor.EmailAddress+%3D+'elacour%40easter-eggs.com'&RowsPerPage=100&SavedChartSearchId=new&SavedSearchId=