RT 3.0.3pre3: bottomline not shown when adding correspondence

After I reply to the ticket in the webinterface,
Ticket/Update.html does not show the bottom line.

Ticket/Update.html output tail:



Download (untitled) 184b

Ticket/Display.html?id=626 output tail:


Download (untitled) 184b
»|« RT 3.0.3pre3 from Best Practical Solutions, LLC.

Stanislav Sinyagin wrote:

Ticket/Update.html does not show the bottom line.

Confirmed. That’s a bug.

/Elements/Footer isn’t being included by the autohandler,
I believe because of an abort() being called.

My mason-fu is weak, so I have no fix to propose. Anyone?
Phil Homewood, Systems Janitor, http://www.SnapGear.com
pdh@snapgear.com Ph: +61 7 3435 2810 Fx: +61 7 3891 3630
SnapGear - Custom Embedded Solutions and Security Appliances

Stanislav Sinyagin wrote:

Ticket/Update.html does not show the bottom line.

My mason-fu is weak, so I have no fix to propose. Anyone?

Sure. This fix has just been committed here.

Thanks,
/Autrijus/

Change 6504 by autrijus@autrinor on 2003/06/13 03:10:23

* instead of abort, say return.

Affected files …

… //depot/RT/rt/html/Ticket/Update.html#24 edit

Differences …

==== //depot/RT/rt/html/Ticket/Update.html#24 (text) ====

@@ -193,7 +193,7 @@

if ( exists $ARGS{SubmitTicket} ) {
$m->comp(‘Display.html’, %ARGS);

  • $m->abort();
  • return;
    }
    </%INIT>

Autrijus Tang wrote:

Sure. This fix has just been committed here.

:slight_smile:

  • $m->abort();
  • return;

There are other abort()s in various Mason pages, as well.
I venture to say that at least some of them will want the
same treatment?

Phil Homewood, Systems Janitor, http://www.SnapGear.com
pdh@snapgear.com Ph: +61 7 3435 2810 Fx: +61 7 3891 3630
SnapGear - Custom Embedded Solutions and Security Appliances

Hi,

A “nice to have” feature request:

the ability to disable the global scrip in a specific queue.

Example:
Global AutoReply scrip sends autoreply notifications
on ticket creation. It is required that one specific queue
does not send them. Or it sends it with a different template.

Currently the only solution is to disable the scrip globally,
and enable it in every queue.

Regards,
Stan

Quoting Stanislav Sinyagin ssinyagin@yahoo.com (2003-06-13 15:29:43 BST):

Hi,

A “nice to have” feature request:

the ability to disable the global scrip in a specific queue.

Example:
Global AutoReply scrip sends autoreply notifications
on ticket creation. It is required that one specific queue
does not send them. Or it sends it with a different template.

Currently the only solution is to disable the scrip globally,
and enable it in every queue.

I’ve just had to do this myself, and I agree wholeheartedly. If I had
any more than 5 queues I’d be cursing RT by now :slight_smile:

LUNDY FASTNET IRISH SEA
VARIABLE 3 OR 4. MAINLY FAIR. MODERATE OR GOOD

A “nice to have” feature request:
the ability to disable the global scrip in a specific queue.

Before RT implements many-to-many scrip-to-queue relationships,
there currently is a hack that is heavily used here.

Namely, a Disabled queue will not have its global scrip activated,
but will have its own scrips activated. See line 132 of
Transaction_Overlay.pm for the details.

You may want to do a Transaction_Local.pm that fine-tunes this
behaviour according to your circumstance

Thanks,
/Autrijus/

[…]

the ability to disable the global scrip in a specific queue.
[…]
Currently the only solution is to disable the scrip globally,
and enable it in every queue.

Not true. You can make a custom condition for the global scrip that is
equivalent to the builtin condition but specifically excludes certain
queues. Not quite the ideal solution, but a whole lot better than
turning off the global scrips and then turning them back on individually
for almost every queue.

-Dan

Daniel E. Eisenbud
eisenbud@cbio.mskcc.org
Computational Biology Center
Memorial Sloan-Kettering Cancer Center