RT 1.3.59 - Eve-before-beta


#1

As of about 3 minutes ago, RT 1.3.59 hit ftp.fsck.com. This release
cleans up the last remaining things on my todo for ‘Beta 1’.

I’d very much like some folks to try hammering on 1.3.59 over the next few
days. When you find bugs, report them to rt-2.0-bugs@fsck.com.

I’d like to release Beta 1 this week. No additional functionality is
targetted at this release, though we have a couple of days to clean
up things that are busted.

One bug to a mail message.

Try to prefix each bug report with one of the following tags:
(they should be pretty obvious. if you don’t know how to tag
a bug, don’t worry about it)

    showstopper
    functionality
    nit
    cosmetic         



    Jesse

2001-03-21 02:46 jesse

    * Makefile:

    yanked some cruft from the ChangeLog creator

2001-03-21 02:44 jesse

    * README:

    Bumped the version. added some people to the readme

2001-03-21 02:39 jesse

    * webrt/Ticket/Elements/ShowBasics:

    Fix for 242: time left displayed via the web ui is now more intuitive

2001-03-21 02:37 jesse

    * bin/rt, bin/rt-mailgate, lib/RT.pm, lib/RT/Attachment.pm,
    lib/RT/Date.pm, lib/RT/Tickets.pm, lib/RT/User.pm:

    Added more error checking and error handling to the mail gateway
    finished code in Attachment.pm to handle too-long attachments

    added support for limiting by date to the CLI

    fixed little bugs in user, date and tickets.

jesse reed vincent – root@eruditorum.orgjesse@fsck.com
70EBAC90: 2A07 FC22 7DB4 42C1 9D71 0108 41A3 3FB3 70EB AC90

And I’m told we do share some common rituals. Our “flame war” is apparently
held in person in their land and called “project meeting”.
-Alan Cox [on “Suits”]


#2

Hi,On Wed, Mar 21, 2001 at 02:54:03AM -0500, Jesse wrote:

As of about 3 minutes ago, RT 1.3.59 hit ftp.fsck.com. This release
cleans up the last remaining things on my todo for ‘Beta 1’.

I’d very much like some folks to try hammering on 1.3.59 over the next few
days. When you find bugs, report them to rt-2.0-bugs@fsck.com.

I’d like to release Beta 1 this week. No additional functionality is
targetted at this release, though we have a couple of days to clean
up things that are busted.

One bug to a mail message.

Try to prefix each bug report with one of the following tags:
(they should be pretty obvious. if you don’t know how to tag
a bug, don’t worry about it)

    showstopper
    functionality
    nit
    cosmetic         

I’m new to RT (first heard about it from freshmeat.net a few weeks
ago, initial view is that it’s great and exactly the kind of thing
that I’ve been waiting for :slight_smile: I’m not sure if these are bugs or not,
which is why I’m reporting them here and not to
rt-2.0-bugs@fsck.com.

I’m testing RT 1.3.59 on debian woody (MTA is exim).

For other exim users: to make RT 1.3.59 work with exim, I set
$MailCommand to ‘sendmail’, and $SendmailArguments to “”. exim
doesn’t like ‘To: “Undiscolosed recipients”;’, so I changed
lib/RT/Action/Notify.pm to set $To = ‘’, which seems to work nicely.
I’ve also added “rt” and “www-data” to “trusted_users” in
"/etc/exim.conf".

I have a scrip configured - “OnComment NotifyAdminWatchersAsComment
with template AdminComment”. This appears to work - admin watchers
are notified, but the email has “From:” set to the correspondence
address rather than the comment address. Is this a bug? I would
expect the “AsComment” actions to have from set to the comment
address.

I’m using an exim rt_pipe transport, I might have read about that
from RT 1 somewhere, can’t remember. After installing a new RT, I
need to always “chmod 755 bin/rt-mailgate” before incoming mail
works. This is probably just a local configuration problem.

An enhancement - we get quite a bit of support email where users CC
their boss, for example. rt-mailgate seems to ignore this
information when creating new tickets. I think that it would be a
good thing if rt-mailgate added other people on the Cc: and To:
lines to it’s own Cc list for the generated tickets (auto creating
users as required). If I get time, I’ll make the required change
myself and post a patch.

Kevin Croombs - Technical Support (support@tao-group.com)
Tao Group (http://www.tao-group.com)


#3

I have a scrip configured - “OnComment NotifyAdminWatchersAsComment
with template AdminComment”. This appears to work - admin watchers
are notified, but the email has “From:” set to the correspondence
address rather than the comment address. Is this a bug?

Yes, I was recently bitten by this. Here’s a fix:

ivan@rootwood:~/RT/work/rt$ cvs diff -u -r1.1
lib/RT/Action/NotifyAsComment.pm
Index: lib/RT/Action/NotifyAsComment.pm
RCS file: /proj/maps/cvsroot/rt/lib/RT/Action/NotifyAsComment.pm,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
— lib/RT/Action/NotifyAsComment.pm 2000/12/19 00:58:37 1.1
+++ lib/RT/Action/NotifyAsComment.pm 2001/03/20 15:02:46 1.2
@@ -2,5 +2,11 @@
require RT::Action::Notify;
@ISA = qw(RT::Action::Notify);

+sub _Init {

  • my $self = shift;
  • $self->{‘comment’} = 1;
  • $self->SUPER::Init(@);
    +}
    1;

I would expect the “AsComment” actions to have from set to the comment
address.

As did I…

meow
_ivan


#4

I have a scrip configured - “OnComment NotifyAdminWatchersAsComment
with template AdminComment”. This appears to work - admin watchers
are notified, but the email has “From:” set to the correspondence
address rather than the comment address. Is this a bug?

Yes, I was recently bitten by this. Here’s a fix:

Thanks

I would expect the “AsComment” actions to have from set to the comment
address.

As did I…

As did I.


meow
_ivan


Rt-devel mailing list
Rt-devel@lists.fsck.com
http://lists.fsck.com/mailman/listinfo/rt-devel

jesse reed vincent – root@eruditorum.orgjesse@fsck.com
70EBAC90: 2A07 FC22 7DB4 42C1 9D71 0108 41A3 3FB3 70EB AC90

They’ll take my private key when they pry it from my cold dead fingers!


#5

Here’s a patch to fix it within the Action API.

RCS file: /raid/cvsroot/rt/lib/RT/Action/Attic/NotifyAsComment.pm,v
retrieving revision 1.1.2.1
diff -u -r1.1.2.1 NotifyAsComment.pm
NotifyAsComment.pm 2000/12/06 04:24:32 1.1.2.1
+++ NotifyAsComment.pm 2001/03/21 17:19:56
@@ -1,6 +1,24 @@
+#$Header$
package RT::Action::NotifyAsComment;
require RT::Action::Notify;
@ISA = qw(RT::Action::Notify);

+=head2 Prepare
+Tell SendEmail that this message should come out as a comment. Then call SUPER::Prepare
+=cut
+sub Prepare {

  •   my $self = shift;
    
  •   #TODO: this should be cleaner.
    
  •   #Tell RT::Action::SendEmail that this should come from the relevant comment email address.
    
  •   $self->{'comment'} = 1;
    
  •   return($self->SUPER::Prepare(@_));      
    

+}
1;On Wed, Mar 21, 2001 at 12:14:02PM -0500, Jesse wrote:

On Wed, Mar 21, 2001 at 09:06:39AM -0800, ivan wrote:

On Wed, Mar 21, 2001 at 04:19:38PM +0000, Kevin Croombs wrote:

I have a scrip configured - “OnComment NotifyAdminWatchersAsComment
with template AdminComment”. This appears to work - admin watchers
are notified, but the email has “From:” set to the correspondence
address rather than the comment address. Is this a bug?

Yes, I was recently bitten by this. Here’s a fix:

Thanks

I would expect the “AsComment” actions to have from set to the comment
address.

As did I…

As did I.


meow
_ivan


Rt-devel mailing list
Rt-devel@lists.fsck.com
http://lists.fsck.com/mailman/listinfo/rt-devel


jesse reed vincent – root@eruditorum.orgjesse@fsck.com
70EBAC90: 2A07 FC22 7DB4 42C1 9D71 0108 41A3 3FB3 70EB AC90

They’ll take my private key when they pry it from my cold dead fingers!


Rt-devel mailing list
Rt-devel@lists.fsck.com
http://lists.fsck.com/mailman/listinfo/rt-devel

jesse reed vincent – root@eruditorum.orgjesse@fsck.com
70EBAC90: 2A07 FC22 7DB4 42C1 9D71 0108 41A3 3FB3 70EB AC90

There are no supercomputer applications that are solvable that cannot be solved
in finite time using a fucking TRS-80 with approprite disk/tape drives. Zero.
-Tanj


#6

Hi,
I’m testing RT 1.3.59 on debian woody (MTA is exim).

For other exim users: to make RT 1.3.59 work with exim, I set
$MailCommand to ‘sendmail’, and $SendmailArguments to “”. exim
doesn’t like ‘To: “Undiscolosed recipients”;’, so I changed
lib/RT/Action/Notify.pm to set $To = ‘’, which seems to work nicely.

Hrm. Time to do more docs digging about what is a reasonable string
to put in a to header that won’t be interpreted.

I have a scrip configured - “OnComment NotifyAdminWatchersAsComment
with template AdminComment”. This appears to work - admin watchers
are notified, but the email has “From:” set to the correspondence
address rather than the comment address. Is this a bug? I would
expect the “AsComment” actions to have from set to the comment
address.

Sorry about that. It’ll be better in .60

I’m using an exim rt_pipe transport, I might have read about that
from RT 1 somewhere, can’t remember. After installing a new RT, I
need to always “chmod 755 bin/rt-mailgate” before incoming mail
works. This is probably just a local configuration problem.

nod the pipe transport does some wacky stuff to call RT directly

An enhancement - we get quite a bit of support email where users CC
their boss, for example. rt-mailgate seems to ignore this
information when creating new tickets. I think that it would be a
good thing if rt-mailgate added other people on the Cc: and To:
lines to it’s own Cc list for the generated tickets (auto creating
users as required). If I get time, I’ll make the required change
myself and post a patch.

http://fsck.com/rt2/Ticket/Display.html?id=259 (login guest/guest) is just
this issue. Some sort of a solution is targetted for Beta 2.

The thing we need to be careful of is not adding watchers that are really
local aliases for RT itself, which RT may not know about.


Kevin Croombs - Technical Support (support@tao-group.com)
Tao Group (http://www.tao-group.com)


Rt-devel mailing list
Rt-devel@lists.fsck.com
http://lists.fsck.com/mailman/listinfo/rt-devel

jesse reed vincent – root@eruditorum.orgjesse@fsck.com
70EBAC90: 2A07 FC22 7DB4 42C1 9D71 0108 41A3 3FB3 70EB AC90

Linux is like a Vorlon. It is incredibly powerful, gives terse,
cryptic answers and has a lot of things going on in the background.