Remove all queue mail addresses in Attachment sub Addresses

Hi,

in lib/RT/Attachment_Overlay.pm sub Addresses there are only the
correspond and comment mail address from the current queue removed.

But there should be all queue mail addresses removed.

I noticed that after the upgrade from 3.6 to 3.8.
At the ticket page, if you go to people there are at
‘Add new watchers’ some entries and on the ticket reply
page there are also some entries at ‘One-time Cc’ and
‘One-time Bcc’. These entries are user (mail addresses)
who appear in the transaction message headers.
They are evaluated with Transaction->Addresses which call
Attachment->Addresses.

If you move a ticket from queue A to queue B, these entries
include the mail address from queue A.

And I hope I’m right, that it don’t make sense to mail from ticket
in queue B to a mail address of queue A as RT recognize this as an
mail loop.

Thanks!
Chris

Christian Loos
Technik, Service Delivery, Network Documentation & Fibre Management

NETCOLOGNE Gesellschaft für Telekommunikation mbH
Am Coloneum 9 | 50829 Köln
Tel: +49-221-2222-276 | Fax: +49-221-2222-7276
www.netcologne.de

Geschäftsführer: Werner Hanf, Dipl.-Ing. Karl-Heinz Zankel
HRB 25580, AG Köln

Attachment_Overlay.pm.patch (1.21 KB)

Hi,

in lib/RT/Attachment_Overlay.pm sub Addresses there are only the
correspond and comment mail address from the current queue removed.

But there should be all queue mail addresses removed.

Hi Chris

If you’ve set RTAddressRegexp in your config, those addresses
shouldn’t show up (see RT::EmailParser->IsRTAddress later in
Attachment::Addresses).

There is some work on a branch to warn about empty regexps and build a
naive one for you, but you’re better off crafting something
site-specific.

Once that branch hits trunk, we’ll probably remove those explicit
queue address checks as a performance hit.

-kevin

Hi Chris

If you’ve set RTAddressRegexp in your config, those addresses
shouldn’t show up (see RT::EmailParser->IsRTAddress later in
Attachment::Addresses).

There is some work on a branch to warn about empty regexps and build a
naive one for you, but you’re better off crafting something
site-specific.

Once that branch hits trunk, we’ll probably remove those explicit
queue address checks as a performance hit.

-kevin

Hi Kevin,

if you do that, think about user like me. Our queue mail addresses have
nothing in common that I can use in RTAddressRegexp.
The only way for me is, to include every single queue mail address in
the RTAddressRegexp. So I have the mail addresses in to places, within
the database in queue table and within the RT_SiteConfig.pm.
Is that really what you want?

Chris

Am 08.02.2010 16:36, schrieb Kevin Falcone:

Hi Chris

If you’ve set RTAddressRegexp in your config, those addresses
shouldn’t show up (see RT::EmailParser->IsRTAddress later in
Attachment::Addresses).

There is some work on a branch to warn about empty regexps and build a
naive one for you, but you’re better off crafting something
site-specific.

Once that branch hits trunk, we’ll probably remove those explicit
queue address checks as a performance hit.

if you do that, think about user like me. Our queue mail addresses have
nothing in common that I can use in RTAddressRegexp.
The only way for me is, to include every single queue mail address in
the RTAddressRegexp. So I have the mail addresses in to places, within
the database in queue table and within the RT_SiteConfig.pm.
Is that really what you want?

Not setting that makes it much easier for you to make RT loop to
itself. We actually just removed code from trunk that loops through
all your queues building the regexp for performance reasons and are
discussing the best way to proceed.

If we had to check every single address with 2 sql queries on a ticket
with 100 attachments, you’d start to notice a serious performance
drag waiting for Update.html to load.

-kevin