I think I had sent patch that covers this situation and do the right
thing! You must check nulls, at least you should check that they are
in results, because such test handles situations when we loose tickets
without requestors.On 11/30/05, alexmv@bestpractical.com alexmv@bestpractical.com wrote:
Author: alexmv
Date: Wed Nov 30 15:26:08 2005
New Revision: 4155
Modified:
rt/branches/QUEBEC-EXPERIMENTAL/ (props changed)
rt/branches/QUEBEC-EXPERIMENTAL/lib/t/regression/20-sort-by-requestor.t
Log:
r7395@zoq-fot-pik: chmrr | 2005-11-30 15:25:32 -0500
- Sort by requestor tests fail on some database backends because they
sort nulls differently than Perl does; only compare non-nulls
Modified: rt/branches/QUEBEC-EXPERIMENTAL/lib/t/regression/20-sort-by-requestor.t
— rt/branches/QUEBEC-EXPERIMENTAL/lib/t/regression/20-sort-by-requestor.t (original)
+++ rt/branches/QUEBEC-EXPERIMENTAL/lib/t/regression/20-sort-by-requestor.t Wed Nov 30 15:26:08 2005
@@ -58,7 +58,7 @@
my @mails;
while (my $t = $tix->Next) { push @mails, $t->RequestorAddresses; }
is(@mails, 6, “found six tickets”);
- is_deeply( @mails, [ sort @mails ], “Addresses are sorted”);
- is_deeply( [grep {$} @mails], [ sort grep {$} @mails ], “Addresses are sorted (exclude nulls, which are db-dependant)”);
}
vim:ft=perl:
Rt-commit mailing list
Rt-commit@lists.bestpractical.com
rt-commit Info Page
Best regards, Ruslan.
I think I had sent patch that covers this situation and do the right
thing! You must check nulls, at least you should check that they are
in results, because such test handles situations when we loose tickets
without requestors.
Any guess on when, so we can dig it out and get it applied?> On 11/30/05, alexmv@bestpractical.com alexmv@bestpractical.com wrote:
Author: alexmv
Date: Wed Nov 30 15:26:08 2005
New Revision: 4155
Modified:
rt/branches/QUEBEC-EXPERIMENTAL/ (props changed)
rt/branches/QUEBEC-EXPERIMENTAL/lib/t/regression/20-sort-by-requestor.t
Log:
r7395@zoq-fot-pik: chmrr | 2005-11-30 15:25:32 -0500
- Sort by requestor tests fail on some database backends because they
sort nulls differently than Perl does; only compare non-nulls
Modified: rt/branches/QUEBEC-EXPERIMENTAL/lib/t/regression/20-sort-by-requestor.t
— rt/branches/QUEBEC-EXPERIMENTAL/lib/t/regression/20-sort-by-requestor.t (original)
+++ rt/branches/QUEBEC-EXPERIMENTAL/lib/t/regression/20-sort-by-requestor.t Wed Nov 30 15:26:08 2005
@@ -58,7 +58,7 @@
my @mails;
while (my $t = $tix->Next) { push @mails, $t->RequestorAddresses; }
is(@mails, 6, “found six tickets”);
- is_deeply( @mails, [ sort @mails ], “Addresses are sorted”);
- is_deeply( [grep {$} @mails], [ sort grep {$} @mails ], “Addresses are sorted (exclude nulls, which are db-dependant)”);
}
vim:ft=perl:
Rt-commit mailing list
Rt-commit@lists.bestpractical.com
rt-commit Info Page
–
Best regards, Ruslan.
Rt-devel mailing list
Rt-devel@lists.bestpractical.com
The rt-devel Archives