PATH: shredder deletes users with valid messages

This patch was cribbed from somewhere else and improved, but it’s
still not integrated into 3.8.4. Can we get this into 3.8.5 please?

— lib/RT/Shredder/Plugin/Users.pm_orig 2009-07-23
13:29:58.000000000 -0700
+++ lib/RT/Shredder/Plugin/Users.pm 2009-07-23 13:31:26.000000000
-0700
@@ -165,7 +165,7 @@
);
}

  • if( $self->{‘opt’}{‘no_tickets’} ) {
  • if( exists( $self->{‘opt’}{‘no_tickets’} ) ) {
    return $self->FilterWithoutTickets(
    Shredder => $args{‘Shredder’},
    Objects => $objs,
    @@ -219,7 +219,8 @@
    sub WithoutTickets {
    my ($self, $user) = @
    ;
    my $tickets = RT::Tickets->new( $RT::SystemUser );
  • $tickets->FromSQL( 'Watcher.id = '. $user->id );
  • $tickets->{‘allow_deleted_search’} = 1;
  • $tickets->FromSQL( 'Watcher.id = ‘. $user->id . ’ OR Creator.id =
    ’. $user->id );

    HACK: we may use Count method which counts all records

    that match condtion, but we really want to know only that

    at least one record exist, so we fetch first row only

Jo Rhett
Net Consonance : consonant endings by net philanthropy, open source
and other randomness

See comments in the ticket you created.On Fri, Jul 24, 2009 at 12:33 AM, Jo Rhettjrhett@netconsonance.com wrote:

This patch was cribbed from somewhere else and improved, but it’s
still not integrated into 3.8.4. Can we get this into 3.8.5 please?

— lib/RT/Shredder/Plugin/Users.pm_orig 2009-07-23
13:29:58.000000000 -0700
+++ lib/RT/Shredder/Plugin/Users.pm 2009-07-23 13:31:26.000000000
-0700
@@ -165,7 +165,7 @@
);
}

  • if( $self->{‘opt’}{‘no_tickets’} ) {
  • if( exists( $self->{‘opt’}{‘no_tickets’} ) ) {
    return $self->FilterWithoutTickets(
    Shredder => $args{‘Shredder’},
    Objects => $objs,
    @@ -219,7 +219,8 @@
    sub WithoutTickets {
    my ($self, $user) = @
    ;
    my $tickets = RT::Tickets->new( $RT::SystemUser );
  • $tickets->FromSQL( 'Watcher.id = '. $user->id );
  • $tickets->{‘allow_deleted_search’} = 1;
  • $tickets->FromSQL( 'Watcher.id = ‘. $user->id . ’ OR Creator.id =
    ’. $user->id );

    HACK: we may use Count method which counts all records

    that match condtion, but we really want to know only that

    at least one record exist, so we fetch first row only


Jo Rhett
Net Consonance : consonant endings by net philanthropy, open source
and other randomness


http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-users

Community help: http://wiki.bestpractical.com
Commercial support: sales@bestpractical.com

Discover RT’s hidden secrets with RT Essentials from O’Reilly Media.
Buy a copy at http://rtbook.bestpractical.com

Best regards, Ruslan.

See my reply. The part of the patch which you refused because it was
"well documented" breaks RT. Not fixing that isn’t something you can
simply “document” – RT falls over. Searches break. Pulling up
tickets break. Pulling reports on users work on tickets break. You
can’t simply “document this behavior”, it’s a must-fix issue.On Jul 23, 2009, at 3:58 PM, Ruslan Zakirov wrote:

See comments in the ticket you created.

On Fri, Jul 24, 2009 at 12:33 AM, Jo Rhettjrhett@netconsonance.com wrote:

This patch was cribbed from somewhere else and improved, but it’s
still not integrated into 3.8.4. Can we get this into 3.8.5
please?

— lib/RT/Shredder/Plugin/Users.pm_orig 2009-07-23
13:29:58.000000000 -0700
+++ lib/RT/Shredder/Plugin/Users.pm 2009-07-23 13:31:26.000000000
-0700
@@ -165,7 +165,7 @@
);
}

  • if( $self->{‘opt’}{‘no_tickets’} ) {
  • if( exists( $self->{‘opt’}{‘no_tickets’} ) ) {
    return $self->FilterWithoutTickets(
    Shredder => $args{‘Shredder’},
    Objects => $objs,
    @@ -219,7 +219,8 @@
    sub WithoutTickets {
    my ($self, $user) = @
    ;
    my $tickets = RT::Tickets->new( $RT::SystemUser );
  • $tickets->FromSQL( 'Watcher.id = '. $user->id );
  • $tickets->{‘allow_deleted_search’} = 1;
  • $tickets->FromSQL( 'Watcher.id = ‘. $user->id . ’ OR
    Creator.id =
    ’. $user->id );

    HACK: we may use Count method which counts all records

    that match condtion, but we really want to know only that

    at least one record exist, so we fetch first row only


Jo Rhett
Net Consonance : consonant endings by net philanthropy, open source
and other randomness


http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-users

Community help: http://wiki.bestpractical.com
Commercial support: sales@bestpractical.com

Discover RT’s hidden secrets with RT Essentials from O’Reilly Media.
Buy a copy at http://rtbook.bestpractical.com


Best regards, Ruslan.

Jo Rhett
Net Consonance : consonant endings by net philanthropy, open source
and other randomness

Demanding work be done by developers who kindly (ie for free) maintain
open source software, in my opinion, borders on being plain rude.
You are free to patch your own version of RT, or find alternative
software which falls more in line with your expectations for ongoing
development. The excuse of being tired and emotional only carries weight
for so long.

Gordon

Jo Rhett wrote:

Jo,

Let me give you simple advice. Don’t attack developers, please.
Instead of proving that you’re right, you started arguing and using
must word. Nobody in this community owes you anything. You didn’t make
you case. Patches are not applied unless bug is obviouse, that’s it.
In the ticket I proved that things work as expected and may be I’m
missing something, but you didn’t describe problem. I even don’t know
how you invoke shredder and I can not try every way.

We can continue arguing on the list or offline, but you brought enough
attention and at this point I do think it’s better to stop it and
start discussing real problem in the ticket.On Fri, Jul 24, 2009 at 4:13 AM, Jo Rhettjrhett@netconsonance.com wrote:

See my reply. The part of the patch which you refused because it was “well
documented” breaks RT. Not fixing that isn’t something you can simply
"document" – RT falls over. Searches break. Pulling up tickets break.
Pulling reports on users work on tickets break. You can’t simply
"document this behavior", it’s a must-fix issue.

On Jul 23, 2009, at 3:58 PM, Ruslan Zakirov wrote:

See comments in the ticket you created.

On Fri, Jul 24, 2009 at 12:33 AM, Jo Rhettjrhett@netconsonance.com wrote:

This patch was cribbed from somewhere else and improved, but it’s
still not integrated into 3.8.4. Can we get this into 3.8.5 please?

— lib/RT/Shredder/Plugin/Users.pm_orig 2009-07-23
13:29:58.000000000 -0700
+++ lib/RT/Shredder/Plugin/Users.pm 2009-07-23 13:31:26.000000000
-0700
@@ -165,7 +165,7 @@
);
}

  • if( $self->{‘opt’}{‘no_tickets’} ) {
  • if( exists( $self->{‘opt’}{‘no_tickets’} ) ) {
    return $self->FilterWithoutTickets(
    Shredder => $args{‘Shredder’},
    Objects => $objs,
    @@ -219,7 +219,8 @@
    sub WithoutTickets {
    my ($self, $user) = @
    ;
    my $tickets = RT::Tickets->new( $RT::SystemUser );
  • $tickets->FromSQL( 'Watcher.id = '. $user->id );
  • $tickets->{‘allow_deleted_search’} = 1;
  • $tickets->FromSQL( 'Watcher.id = ‘. $user->id . ’ OR Creator.id =
    ’. $user->id );
# HACK: we may use Count method which counts all records
# that match condtion, but we really want to know only that
# at least one record exist, so we fetch first row only


Jo Rhett
Net Consonance : consonant endings by net philanthropy, open source
and other randomness


http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-users

Community help: http://wiki.bestpractical.com
Commercial support: sales@bestpractical.com

Discover RT’s hidden secrets with RT Essentials from O’Reilly Media.
Buy a copy at http://rtbook.bestpractical.com


Best regards, Ruslan.


Jo Rhett
Net Consonance : consonant endings by net philanthropy, open source and
other randomness

Best regards, Ruslan.

Gordon, I didn’t demand anything. I (for free, as you said) supplied
a patch which makes the software work. Without the patch, the
software does not function. The person I was replying to was making
an argument that this wasn’t necessary, and my text quoted below was
simply making the point that it was necessary. Without the patch, db
inconsistency can make loading tickets impossible. And without the
patch, it errors out rather than completing the job. There’s nothing
"tired" or “emotional” about this, it’s plain fact.On Jul 23, 2009, at 5:32 PM, gordon@cryologic.com wrote:

Demanding work be done by developers who kindly (ie for free) maintain
open source software, in my opinion, borders on being plain rude.
You are free to patch your own version of RT, or find alternative
software which falls more in line with your expectations for ongoing
development. The excuse of being tired and emotional only carries
weight
for so long.

Gordon

Jo Rhett wrote:

See my reply. The part of the patch which you refused because it
was
"well documented" breaks RT. Not fixing that isn’t something you can
simply “document” – RT falls over. Searches break. Pulling up
tickets break. Pulling reports on users work on tickets break. You
can’t simply “document this behavior”, it’s a must-fix issue.


http://lists.bestpractical.com/cgi-bin/mailman/listinfo/rt-users

Community help: http://wiki.bestpractical.com
Commercial support: sales@bestpractical.com

Discover RT’s hidden secrets with RT Essentials from O’Reilly Media.
Buy a copy at http://rtbook.bestpractical.com

Jo Rhett
Net Consonance : consonant endings by net philanthropy, open source
and other randomness