Patch review request: Incorrect evaluation of ACLS in mail gateway when no queue is specified

RT Developers
1

Hi,

I’ve just filed a bug at

http://rt3.fsck.com/Ticket/Display.html?id=14360

detailing a recent problem we’ve discovered following the upgrade
of one of our RT instances from RT2 to RT 3.8.7.

I’ve attached a patch which I’ve verified fixes the problem on our
test system. I would appreciate if someone knowledgable in this area
of the RT code base could cast their eye over the patch to make sure
it makes sense before I deploy it on our production system (I am
slightly nervous since regressions introduced into the mail gateway
code is likely to be very visible to end users).

Cheers,
Dominic.

Dominic Hargreaves, Systems Development and Support Team
Computing Services, University of Oxford

bugfix_mail_gateway_queue_selection.patch (1.42 KB)

signature.asc (197 Bytes)

2

Hi,

I’ve just filed a bug at

http://rt3.fsck.com/Ticket/Display.html?id=14360

detailing a recent problem we’ve discovered following the upgrade
of one of our RT instances from RT2 to RT 3.8.7.

I’ve attached a patch which I’ve verified fixes the problem on our
test system. I would appreciate if someone knowledgable in this area
of the RT code base could cast their eye over the patch to make sure
it makes sense before I deploy it on our production system (I am
slightly nervous since regressions introduced into the mail gateway
code is likely to be very visible to end users).

After some internal review, I have made a small change to catch a
possible error condition, rolled it out in production, and sent the
patch to the ticket.

Dominic Hargreaves, Systems Development and Support Team
Computing Services, University of Oxford

signature.asc (197 Bytes)