RT 3.4.1 contains two copies of ParseTicketId, one in
RT::EmailParser::ParseTicketId, and another one in
RT::Interface:
:ParseTicketId.
Apart from some calling convention issue, they are identical. Is this
code duplication really necessary? This is a likely place of
customization, and it would be nice if I needn’t apply patches to both
variants.
RT 3.4.1 contains two copies of ParseTicketId, one in
RT::EmailParser::ParseTicketId, and another one in
RT::Interface::ParseTicketId.
Apart from some calling convention issue, they are identical. Is this
code duplication really necessary? This is a likely place of
customization, and it would be nice if I needn’t apply patches to both
variants.
No. One of them is supposed to have been removed. Off the top of my
head, I don’t recall which.
RT 3.4.1 contains two copies of ParseTicketId, one in
RT::EmailParser::ParseTicketId, and another one in
RT::Interface:Apart from some calling convention issue, they are identical. Is this
code duplication really necessary? This is a likely place of
customization, and it would be nice if I needn’t apply patches to both
variants.No. One of them is supposed to have been removed. Off the top of my
head, I don’t recall which.
The version in RT::EmailParser is the older one. I had to apply my
patch to RT::Interface::ParseTicketId to enable it again
because RT::EmailParser::ParseTicketId is no longer called. (However,
I’m not sure if it’s really dead.)
The version in RT::EmailParser is the older one. I had to apply my
patch to RT::Interface:
because RT::EmailParser::ParseTicketId is no longer called. (However,
I’m not sure if it’s really dead.)
So. EmailParser is actually newer. I believe the intent was to move to
using it as an OO API for email parsing rather than the old code in
Interface::Email. I’d also thought that alex had cleaned this stuff up
on the RT 3.4 branch 
The version in RT::EmailParser is the older one. I had to apply my
patch to RT::Interface:
because RT::EmailParser::ParseTicketId is no longer called. (However,
I’m not sure if it’s really dead.)So. EmailParser is actually newer.
Huh? The version in RT::Interface::Email appeared in 3.4.0 according
to my logs. 3.2.2 didn’t have it. The version in RT::EmailParser has
been there from pretty much the beginning (it’s even in 3.0.x).
- Jesse Vincent:
The version in RT::EmailParser is the older one. I had to apply my
patch to RT::Interface:
because RT::EmailParser::ParseTicketId is no longer called. (However,
I’m not sure if it’s really dead.)So. EmailParser is actually newer.
Huh? The version in RT::Interface::Email appeared in 3.4.0 according
to my logs. 3.2.2 didn’t have it. The version in RT::EmailParser has
been there from pretty much the beginning (it’s even in 3.0.x).
Ok. now I’m confused. I thought this code had been in
Interface::Email since RT 2.0 and only recently (3.2ish) appeared in
EmailParser. Anyway, the unused one should get whacked.