Minor patch

The following patch prevents an error message about “Unknown update
type” on my RT installation whenever I try to update a multi-choice
custom field with categories.

— lib/RT/Interface/Web.pm 2007-07-19 22:30:01.000000000 +0300
+++ local/lib/RT/Interface/Web.pm 2007-10-07 15:10:17.000000000 +0300
@@ -1281,6 +1281,7 @@
s/\r//g foreach @values;
}
@values = grep defined && $_ ne ‘’, @values;

  •    next if $arg =~ /Category$/;
    
       if ( $arg eq 'AddValue' || $arg eq 'Value' ) {
           foreach my $value (@values) {

Thanks for the patch. That looks like a kind of strange place to put
that skip. Is there a reason it’s not at the start of the loop?

-jesseOn Oct 8, 2007, at 4:03 AM, Brian Gallew wrote:

The following patch prevents an error message about “Unknown update
type” on my RT installation whenever I try to update a multi-choice
custom field with categories.

— lib/RT/Interface/Web.pm 2007-07-19 22:30:01.000000000 +0300
+++ local/lib/RT/Interface/Web.pm 2007-10-07
15:10:17.000000000 +0300
@@ -1281,6 +1281,7 @@
s/\r//g foreach @values;
}
@values = grep defined && $_ ne ‘’, @values;

  •    next if $arg =~ /Category$/;
      if ( $arg eq 'AddValue' || $arg eq 'Value' ) {
          foreach my $value (@values) {
    

The rt-users Archives

Community help: http://wiki.bestpractical.com
Commercial support: sales@bestpractical.com

Discover RT’s hidden secrets with RT Essentials from O’Reilly
Media. Buy a copy at http://rtbook.bestpractical.com

PGP.sig (186 Bytes)

Jesse Vincent wrote:

Thanks for the patch. That looks like a kind of strange place to put
that skip. Is there a reason it’s not at the start of the loop?

“Because I backtracked to the first place that looked reasonable.” :sunglasses:

I have no preferences here, as long as it works!

Ok. Applied :)On Oct 9, 2007, at 1:35 AM, Brian Gallew wrote:

Jesse Vincent wrote:

Thanks for the patch. That looks like a kind of strange place to
put that skip. Is there a reason it’s not at the start of the loop?

“Because I backtracked to the first place that looked reasonable.”
:sunglasses:

I have no preferences here, as long as it works!


The rt-users Archives

Community help: http://wiki.bestpractical.com
Commercial support: sales@bestpractical.com

Discover RT’s hidden secrets with RT Essentials from O’Reilly
Media. Buy a copy at http://rtbook.bestpractical.com

PGP.sig (186 Bytes)