Hardcoded Bookmarked Ticked Rows to 999 by Ruz

RT Users
1

One user complained about broken “Rows per page” in “Bookmarken Tickets”.
After some searching I found this commit in html/Elements/ShowSearch:

It contains hardcoded limit for Bookmarked tickets:
if ( $->{‘Query’} =~ /Bookmarked/ ) {
$->{‘Rows’} = 999;
}
elsif ( $->{‘Query’} =~ /Bookmarks/ ) {
$->{‘Rows’} = 999;

Is it necessary for some functionality? Is it safe to remove this condition
in local copy of ShowSearch file?

Thanks in advance.

Best regards,

Pavel

Pavel Šidlo

LinuxBox.cz, s.r.o.
28. října 168, 709 00 Ostrava

tel.: +420 591 166 234
mob.: +420 737 238 334
web: www.linuxbox.cz

mobil servis: +420 737 238 656
email servis: servis@linuxbox.cz

2

One user complained about broken “Rows per page” in “Bookmarken Tickets”. After some searching
I found this commit in html/Elements/ShowSearch:
[1]more on Bookmarks · bestpractical/rt@00257ea · GitHub

It contains hardcoded limit for Bookmarked tickets:
if ( $->{‘Query’} =~ /Bookmarked/ ) {
$->{‘Rows’} = 999;
}
elsif ( $->{‘Query’} =~ /Bookmarks/ ) {
$->{‘Rows’} = 999;

Is it necessary for some functionality? Is it safe to remove this condition in local copy of
ShowSearch file?

I suspect this dates from 3.8.0/3.8.1 when Bookmarks were presented as
a very custom search, rather than as “id = ‘Bookmarked’”

While the latter part should remain because it’s more or less a dead
path, do you want to try out the following patch and see if it fixes
what your user is seeing?

https://github.com/bestpractical/rt/commit/240a9e033394a6d95cb2af4ed6ee452b060ef165.patch

You’ll want to clear your mason cache and restart apache after
applying.

-kevin