Fixing up RT for Postgres 7.3

I was starting to poke around DBIx::SearchBuilder for any fixes that
might be needed for Postgres 7.3. I’m not seeing how SearchBuilder
really knows which DB it is using when, for example, generating the
LIMIT clause. The one there never should have worked considering that
PG implemented LIMIT X,Y backwards from MySQL (the offset/count order
was reversed). This is why the preferred LIMIT X OFFSET Y format was
kept in favor of the other format.

So, how does it tell which DB it is using when generating these
things? Do I just override the method in SearchBuilder’s Pg module?

Once that’s fixed, it is on to track down all the implicit ‘’ => 0
casts that need to be found and fixed…

Vivek Khera, Ph.D. Khera Communications, Inc.
Internet: khera@kciLink.com Rockville, MD +1-240-453-8497
AIM: vivekkhera Y!: vivek_khera http://www.khera.org/~vivek/

have a look at 0.75. there’s a new Handle->Version method that can be
used as a base for this.On Fri, Jan 10, 2003 at 03:06:37PM -0500, Vivek Khera wrote:

I was starting to poke around DBIx::SearchBuilder for any fixes that
might be needed for Postgres 7.3. I’m not seeing how SearchBuilder
really knows which DB it is using when, for example, generating the
LIMIT clause. The one there never should have worked considering that
PG implemented LIMIT X,Y backwards from MySQL (the offset/count order
was reversed). This is why the preferred LIMIT X OFFSET Y format was
kept in favor of the other format.

So, how does it tell which DB it is using when generating these
things? Do I just override the method in SearchBuilder’s Pg module?

Once that’s fixed, it is on to track down all the implicit ‘’ => 0
casts that need to be found and fixed…


=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Vivek Khera, Ph.D. Khera Communications, Inc.
Internet: khera@kciLink.com Rockville, MD +1-240-453-8497
AIM: vivekkhera Y!: vivek_khera http://www.khera.org/~vivek/


rt-devel mailing list
rt-devel@lists.fsck.com
http://lists.fsck.com/mailman/listinfo/rt-devel

»|« http://www.bestpractical.com/rt – Trouble Ticketing. Free.

New answer:

RT 2.1.62 passes its test suite on Postgres 7.3.1.

I know that the test suite is not testing the LIMIT stuff yet.

I’m sure that there’s other stuff we’re missing, but it would be great
if you could start to hammer on it.

-jesseOn Fri, Jan 10, 2003 at 03:11:21PM -0500, Jesse Vincent wrote:

have a look at 0.75. there’s a new Handle->Version method that can be
used as a base for this.

On Fri, Jan 10, 2003 at 03:06:37PM -0500, Vivek Khera wrote:

I was starting to poke around DBIx::SearchBuilder for any fixes that
might be needed for Postgres 7.3. I’m not seeing how SearchBuilder
really knows which DB it is using when, for example, generating the
LIMIT clause. The one there never should have worked considering that
PG implemented LIMIT X,Y backwards from MySQL (the offset/count order
was reversed). This is why the preferred LIMIT X OFFSET Y format was
kept in favor of the other format.

So, how does it tell which DB it is using when generating these
things? Do I just override the method in SearchBuilder’s Pg module?

Once that’s fixed, it is on to track down all the implicit ‘’ => 0
casts that need to be found and fixed…


=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Vivek Khera, Ph.D. Khera Communications, Inc.
Internet: khera@kciLink.com Rockville, MD +1-240-453-8497
AIM: vivekkhera Y!: vivek_khera http://www.khera.org/~vivek/


rt-devel mailing list
rt-devel@lists.fsck.com
http://lists.fsck.com/mailman/listinfo/rt-devel


»|« http://www.bestpractical.com/rt – Trouble Ticketing. Free.


rt-devel mailing list
rt-devel@lists.fsck.com
http://lists.fsck.com/mailman/listinfo/rt-devel

»|« http://www.bestpractical.com/rt – Trouble Ticketing. Free.