Fixes for attachments / rt3

Nicolae_P_Costescu · May 19, 2003, 3:02pm

I have applied Art’s patch and it does fix attachments for me. I’m also
running RH8.0 US version.
Thank you Art!

At 09:15 AM 5/19/2003 -0400, you wrote:

These patches only fix the attachments through the web, not the mailgate
yet.

Art

-----Original Message-----
From: Autrijus Tang [mailto:autrijus@autrijus.org]
Sent: Thursday, May 15, 2003 8:26 AM
To: Art Morales
Cc: rt-users@lists.fsck.com
Subject: Re: [rt-users] Official Attachment Status

Hello,

After reading through the archives, I’m not entirely clear if
attachments are supposed to be working in the latest version (3.0.2).
Mine aren’t, so before I dig down to figure out what I did wrong, I
was wondering if we could get the official word. I’m running RH8,
apache2/modperl1.99 (everything else works great)

Unicode-characters in WebUI’s “file attachments” has been fixed here by
the change below. Hadn’t tested it with the mail-gateway, though.

Thanks,
/Autrijus/

Change 5860 by autrijus@ehrtest on 2003/05/15 12:00:25
    * utf8 filenames in attachments is now ok.
    * no longer attempts to convert web-attached textual parts into
utf8, only the body.

Affected files …

… //depot/RT/rt/lib/RT/Attachment_Overlay.pm#18 edit
… //depot/RT/rt/lib/RT/Interface/Web.pm#50 edit

Differences …

==== //depot/RT/rt/lib/RT/Attachment_Overlay.pm#18 (text) ====

@@ -136,7 +136,10 @@
chomp($Subject);
 #Get the filename
my $Filename = $Attachment->head->recommended_filename;
my $Filename = $Attachment->head->recommended_filename || eval {
  ${ $Attachment->head->{mail_hdr_hash}{'Content-Disposition'}[0]
}
      =~ /^.*\bfilename="(.*)"$/ ? $1 : ''
};

if ( $Attachment->parts ) {
$id = $self->SUPER::Create(
==== //depot/RT/rt/lib/RT/Interface/Web.pm#50 (text) ====

@@ -453,6 +453,8 @@
);
}

RT::I18N::SetMIMEEntityToUTF8($Message); # convert text parts into

utf-8

my $cgi_object = $m->cgi_object;

if (my $filehandle = $cgi_object->upload(
$args{‘AttachmentFieldName’} ) ) { @@ -478,10 +480,11 @@
$filename = “$filehandle” unless defined($filename);

$filename =~ s#^.*[\/]##;

$Message->attach(
Path => $temp_file,
   Filename => $filename,
   Type     => $uploadinfo->{'Content-Type'}
   Filename => Encode::decode_utf8($filename),
   Type     => $uploadinfo->{'Content-Type'},
);
close($fh);
@@ -490,7 +493,6 @@
}
 $Message->make_singlepart();
RT::I18N::SetMIMEEntityToUTF8($Message); # convert text parts into
utf-8
return ($Message);

}

-----Original Message-----
From: Nicolae P. Costescu [mailto:nick@strongholdtech.com]
Sent: Monday, May 19, 2003 9:18 AM
To: Art Morales
Subject: RE: fixes for attachments / rt3

Art
If you happen to have that msg handy would you mind sending it to me? I
also am using RH8 US version. Thanks Nick

At 09:50 PM 5/16/2003 -0400, you wrote:
The fixes are the ones on the message I last sent (I included the
original
email in my response). The attachment issue is a known issue I guess
with
some systems. I have the problem in RH8, US version… may not be a
problem in other installations.

Art
    -----Original Message-----
    From: Nicolae P. Costescu [mailto:nick@strongholdtech.com]
    Sent: Fri 5/16/2003 4:59 PM
    To: Art Morales
    Cc:
    Subject: fixes for attachments / rt3



    Art
    Which fixes did you apply?
    Is this a know pblm (with the attachments)?
    Thanks
    Nick


    ****************************************************
    Nicolae P. Costescu, Ph.D.  / Senior Developer
    Stronghold Technologies
    46040 Center Oak Plaza, Suite 160 / Sterling, Va 20166
    Tel: 571-434-1472 / Fax: 571-434-1478
Nicolae P. Costescu, Ph.D. / Senior Developer
Stronghold Technologies
46040 Center Oak Plaza, Suite 160 / Sterling, Va 20166
Tel: 571-434-1472 / Fax: 571-434-1478

Nicolae P. Costescu, Ph.D. / Senior Developer
Stronghold Technologies
46040 Center Oak Plaza, Suite 160 / Sterling, Va 20166
Tel: 571-434-1472 / Fax: 571-434-1478

Art_Morales · May 19, 2003, 2:58pm

Just to note, this wasn’t my patch

Credit of course goes to Autrijus Tang…

ArtFrom: Nicolae P. Costescu [mailto:nick@strongholdtech.com]
Sent: Monday, May 19, 2003 11:02 AM
To: Art Morales
Cc: rt-users@lists.fsck.com
Subject: RE: fixes for attachments / rt3

I have applied Art’s patch and it does fix attachments for me. I’m also
running RH8.0 US version.
Thank you Art!

At 09:15 AM 5/19/2003 -0400, you wrote:

These patches only fix the attachments through the web, not the
mailgate yet.

Art

-----Original Message-----
From: Autrijus Tang [mailto:autrijus@autrijus.org]
Sent: Thursday, May 15, 2003 8:26 AM
To: Art Morales
Cc: rt-users@lists.fsck.com
Subject: Re: [rt-users] Official Attachment Status

Hello,

After reading through the archives, I’m not entirely clear if
attachments are supposed to be working in the latest version
(3.0.2). Mine aren’t, so before I dig down to figure out what I did
wrong, I was wondering if we could get the official word. I’m
running RH8, apache2/modperl1.99 (everything else works great)

Unicode-characters in WebUI’s “file attachments” has been fixed here by

the change below. Hadn’t tested it with the mail-gateway, though.

Thanks,
/Autrijus/

Change 5860 by autrijus@ehrtest on 2003/05/15 12:00:25
    * utf8 filenames in attachments is now ok.
    * no longer attempts to convert web-attached textual parts 
into utf8, only the body.

Affected files …

… //depot/RT/rt/lib/RT/Attachment_Overlay.pm#18 edit
… //depot/RT/rt/lib/RT/Interface/Web.pm#50 edit

Differences …

==== //depot/RT/rt/lib/RT/Attachment_Overlay.pm#18 (text) ====

@@ -136,7 +136,10 @@
chomp($Subject);
 #Get the filename
my $Filename = $Attachment->head->recommended_filename;
my $Filename = $Attachment->head->recommended_filename || eval {
  ${ $Attachment->head->{mail_hdr_hash}{'Content-Disposition'}[0]
}
      =~ /^.*\bfilename="(.*)"$/ ? $1 : ''
};

if ( $Attachment->parts ) {
$id = $self->SUPER::Create(
==== //depot/RT/rt/lib/RT/Interface/Web.pm#50 (text) ====

@@ -453,6 +453,8 @@
);
}

RT::I18N::SetMIMEEntityToUTF8($Message); # convert text parts into

utf-8

my $cgi_object = $m->cgi_object;

if (my $filehandle = $cgi_object->upload(
$args{‘AttachmentFieldName’} ) ) { @@ -478,10 +480,11 @@
$filename = “$filehandle” unless defined($filename);

$filename =~ s#^.*[\/]##;

$Message->attach(
Path => $temp_file,
   Filename => $filename,
   Type     => $uploadinfo->{'Content-Type'}
   Filename => Encode::decode_utf8($filename),
   Type     => $uploadinfo->{'Content-Type'},
);
close($fh);
@@ -490,7 +493,6 @@
}
 $Message->make_singlepart();
RT::I18N::SetMIMEEntityToUTF8($Message); # convert text parts into
utf-8
return ($Message);

}

-----Original Message-----
From: Nicolae P. Costescu [mailto:nick@strongholdtech.com]
Sent: Monday, May 19, 2003 9:18 AM
To: Art Morales
Subject: RE: fixes for attachments / rt3

Art
If you happen to have that msg handy would you mind sending it to me? I

also am using RH8 US version. Thanks Nick

At 09:50 PM 5/16/2003 -0400, you wrote:
The fixes are the ones on the message I last sent (I included the
original email in my response). The attachment issue is a known
issue I guess
with
some systems. I have the problem in RH8, US version… may not be a
problem in other installations.

Art
    -----Original Message-----
    From: Nicolae P. Costescu [mailto:nick@strongholdtech.com]
    Sent: Fri 5/16/2003 4:59 PM
    To: Art Morales
    Cc:
    Subject: fixes for attachments / rt3



    Art
    Which fixes did you apply?
    Is this a know pblm (with the attachments)?
    Thanks
    Nick


    ****************************************************
    Nicolae P. Costescu, Ph.D.  / Senior Developer
    Stronghold Technologies
    46040 Center Oak Plaza, Suite 160 / Sterling, Va 20166
    Tel: 571-434-1472 / Fax: 571-434-1478
Nicolae P. Costescu, Ph.D. / Senior Developer
Stronghold Technologies
46040 Center Oak Plaza, Suite 160 / Sterling, Va 20166
Tel: 571-434-1472 / Fax: 571-434-1478

Nicolae P. Costescu, Ph.D. / Senior Developer
Stronghold Technologies
46040 Center Oak Plaza, Suite 160 / Sterling, Va 20166
Tel: 571-434-1472 / Fax: 571-434-1478