DBIx-SB: new tests, fixes and cleanups

RT Developers
1

Heya!
Changes:

  • rewrite LoadByPrimaryKeys args handling to consistent with other Load*
    methods
  • report error when PK filed is missing in LoadByPrimaryKeys
  • fix warning in __Set methods when newvalue is undef
  • small code cleanups

Tests:

  • coverage grows from 75.2% to 84.7% for Record.pm

Best regards, Ruslan.

tests.patch (11.6 KB)

2

Heya, guys.
Patch attached that fixes issue on Pg as suggested and uncomment tests.

Now I have system where I can test firebird, mysql, pg and sqlite, so
next time I would be testing my patches with all backends.

Best regards, Ruslan.

Ruslan U. Zakirov wrote:

3

Heya, guys.
Patch attached that fixes issue on Pg as suggested and uncomment tests.

Except it’s not :frowning:

4

as usual :slight_smile:

David Glasser wrote:

pg_and_strict_integer_handling.patch (1.97 KB)