Bug in RT3.0.11 RT::Ticket::SetStatus

RT Developers
1

Looks like there is a misspelled status name in lib/RT/Ticket_Overlay.pm

3317c3317
< if ( $args{Status} =~ /^(resolved|rejected|dead)$/ ) {

if ( $args{Status} =~ /^(resolved|rejected|deleted)$/ ) {

Best regards,

Ruediger Riediger

Dr. Ruediger Riediger Sun Microsystems GmbH
NSG - SunCERT Komturstr. 18a
mailto:Ruediger.Riediger@Sun.com D-12099 Berlin
NOTICE: This email message is for the sole use of the intended
recipient(s) and may contain confidential and privileged information.
Any unauthorized review, use, disclosure or distribution is prohibited.
If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
PGP 2048RSA/0x2C5020E9 964C E189 0FF0 8882 2BAB 65E2 6912 1FF2

2

Looks like there is a misspelled status name in lib/RT/Ticket_Overlay.pm

3317c3317
< if ( $args{Status} =~ /^(resolved|rejected|dead)$/ ) {

if ( $args{Status} =~ /^(resolved|rejected|deleted)$/ ) {

This bug is also present in the same file in RT 3.2.2.

Stephen

3

Looks like there is a misspelled status name in lib/RT/Ticket_Overlay.pm

3317c3317
< if ( $args{Status} =~ /^(resolved|rejected|dead)$/ ) {

if ( $args{Status} =~ /^(resolved|rejected|deleted)$/ ) {

This bug is also present in the same file in RT 3.2.2.

Yep. and actually, it should be using $self->QueueObj->IsInactiveStatus.
Anyone want to hand me a patch while I’m off debugging issues with the
latest DBD::Oracle and MIME::Tools?

4

Looks like there is a misspelled status name in lib/RT/Ticket_Overlay.pm

3317c3317
< if ( $args{Status} =~ /^(resolved|rejected|dead)$/ ) {

if ( $args{Status} =~ /^(resolved|rejected|deleted)$/ ) {

This bug is also present in the same file in RT 3.2.2.

Yep. and actually, it should be using $self->QueueObj->IsInactiveStatus.
Anyone want to hand me a patch while I’m off debugging issues with the
latest DBD::Oracle and MIME::Tools?

Here’s a patch which should do the correct thing for 3.0.12:

— request-tracker3-3.0.12.orig/lib/RT/Ticket_Overlay.pm
+++ request-tracker3-3.0.12/lib/RT/Ticket_Overlay.pm
@@ -3314,7 +3314,7 @@
RecordTransaction => 0 );
}

  • if ( $args{Status} =~ /^(resolved|rejected|dead)$/ ) {

  • if ( $self->QueueObj->IsInactiveStatus($args{Status}) ) {

    #When we resolve a ticket, set the 'Resolved' attribute to now.
$self->_Set( Field             => 'Resolved',

Here’s a patch for 3.2.2:

— request-tracker3.2-3.2.2.orig/lib/RT/Ticket_Overlay.pm
+++ request-tracker3.2-3.2.2/lib/RT/Ticket_Overlay.pm
@@ -3191,7 +3191,7 @@
RecordTransaction => 0 );
}

  • if ( $args{Status} =~ /^(resolved|rejected|dead)$/ ) {

  • if ( $self->QueueObj->IsInactiveStatus($args{Status}) ) {

    #When we resolve a ticket, set the 'Resolved' attribute to now.
$self->_Set( Field             => 'Resolved',

I will apply the patch to the 3.0.12 request-tracker3 package in
Debian shortly to make sure the fix gets into sarge.

Stephen Quinney

signature.asc (189 Bytes)