Approvals linked to multiple tickets

Loos_Christian · October 15, 2014, 3:17pm

Hi,

currently have the request to make an approval linked to two tickets.

Testing the approval work flow I noticed that only one ticket is
rejected if I reject the approval.
Is there any reason why [1] expect there is only one linked ticket?

Chris

[1]

github.com

bestpractical/rt/blob/stable/lib/RT/Approval/Rule/Rejected.pm#L66


      
          sub Prepare {
              my $self = shift;
              return unless $self->SUPER::Prepare();
          
          
    return (0)
                  unless $self->OnStatusChange('rejected') or $self->OnStatusChange('deleted')
          }
          
          
sub Commit {    # XXX: from custom prepare code
              my $self = shift;
              if ( my ($rejected) =
                  $self->TicketObj->AllDependedOnBy( Type => 'ticket' ) ) {
                  my $note = $self->GetNotes;
          
          
        my $template = $self->GetTemplate('Approval Rejected',
                                                    TicketObj => $rejected,
                                                    Approval  => $self->TicketObj,
                                                    Approver  => $self->TransactionObj->CreatorObj,
                                                    Notes     => $note);
          
          
        $rejected->Correspond( MIMEObj => $template->MIMEObj );

Kevin_Falcone · October 15, 2014, 9:07pm

currently have the request to make an approval linked to two tickets.

Testing the approval work flow I noticed that only one ticket is
rejected if I reject the approval.
Is there any reason why [1] expect there is only one linked ticket?

Looks like the engineer who moved this code out of Scrips and into
Rules thought it fixed a bug? At least there’s a test, which is what
I’ve found most useful when trying to figure out what this refactor
was trying to accomplish.

I assume you have the scenario where
Ticket1
Ticket2
Approval1

Approval1 is dependedon by Ticket1
AND
Approval1 is dependedon by Ticket2

I see no reason why we should continue to fail in that case.

-kevin